Allow ARIA label with token support

Created on 2 November 2022, about 2 years ago
Updated 2 October 2023, about 1 year ago

Problem/Motivation

This is great module. I used this module for brand kit table. Our table shows download now link multiple times for different files. As per ADA, we need to add aria-label to provide more detail to screen readers.

Steps to reproduce

Proposed resolution

Added configuration for aria-label in field formatter settings with token support. So we can configure the parent field values as aria-label.

Remaining tasks

User interface changes

API changes

Data model changes

Feature request
Status

Needs review

Version

2.0

Component

Code

Created by

🇮🇳India iyyappan.govind Chennai, India

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7
    last update about 1 year ago
    27 pass, 2 fail
  • @chrissnyder opened merge request.
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7
    last update about 1 year ago
    29 pass
  • Status changed to Needs review about 1 year ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7
    last update about 1 year ago
    29 pass
  • 🇺🇸United States chrissnyder Maryland

    Thank you for your work on this @iyyappan.govind!

    I've opened a MR with the changes from the above patch and made a few changes to ensure that tests still pass and this functionally will still work if the token module is not installed.

    Attached is a patch mirroring the MR for patching your own project.

  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7
    last update about 1 year ago
    29 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7
    last update about 1 year ago
    29 pass
  • 🇺🇸United States chrissnyder Maryland

    Update patch file with the recent fix to aria label HTML attribute.

  • 🇺🇸United States chrissnyder Maryland

    Note: Currently, the patch will not apply to the current stable 2.0.3 version of this module. In order to apply this patch to your site/project, you will need to include additional commits/patches that are currently only on the dev branch.

    If using composer-patches, update your composer.json with the following in the "patches" config:

                "drupal/file_download_link" : {
                    "3268442 - File Download Link functional js tests failing": "https://git.drupalcode.org/project/file_download_link/-/commit/f144895000bc5543db3e953854debb8faf5a4f05.patch",
                    "3333961 - Enhance file_download_link XSS test": "https://git.drupalcode.org/project/file_download_link/-/commit/d0827350d0a36fd0ac1deff78182da8b2b9c356d.patch",
                    "3349706 - Refactor file_download_link Kernel tests": "https://git.drupalcode.org/project/file_download_link/-/commit/c67506244dd6bfb9b02fddbed85bfc2854ceaeb8.patch",
                    "3318657 - Support ARIA label": "https://www.drupal.org/files/issues/2023-10-02/file_download_link-support_aria_label-3318657-10.patch"
                }
    
Production build 0.71.5 2024