Original GH issue: https://github.com/nuvoleweb/ui_patterns/issues/298
Original GH PR: https://github.com/nuvoleweb/ui_patterns/pull/299
If we are on the admin theme, and we have pattern definitions inside another theme (e.g: your main theme), then the path in hook_theme() definitions are not correct.
This is because LibraryPattern::processCustomThemeHookProperty only takes into account modules.
protected function processCustomThemeHookProperty(PatternDefinition $definition) {
/** @var \Drupal\Core\Extension\Extension $module */
$return = [];
if (!$definition->hasCustomThemeHook() && $this->moduleHandler->moduleExists($definition->getProvider())) {
$module = $this->moduleHandler->getModule($definition->getProvider());
$return['path'] = $module->getPath() . '/templates';
if ($this->templateExists($definition->getBasePath(), $definition->getTemplate())) {
$return['path'] = str_replace($this->root, '', $definition->getBasePath());
}
}
return $return;
}This breaks for example the preview when we are in the Views admin and other patterns usages when the active theme is not the one that contains the definitions.
Needs work
1.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
We're still using this PR. I'll copy over the MR as patch. However this issue needs steps to reproduce and as mentioned in the PR it needs tests also.
As it seems we're the only one still using the patch, I tried to reproduce this with the latest version and can't seem to reproduce this. For me this can be closed.