Gin Admin Table styling issue on Media admin view

Created on 12 October 2022, almost 2 years ago
Updated 30 May 2024, 4 months ago

Problem

On the Media admin view, the paging links at the bottom of the page cannot be clicked. This is because the table of media items has styles applied to it that cause it to overlay the paging links. Here are the specific styles that are an issue:

.gin-table-scroll-wrapper {
  overflow: auto;
  -webkit-overflow-scrolling: touch;
  padding-bottom: 240px;
  margin-bottom: -240px;
}

I was able to avoid the issue by, in the browser developer tools, turning off the padding-bottom and margin-bottom styles. I'm not sure why those styles are there, but they are an issue.

This style is on many admin tables, and I cannot figure out why this problem seems to affect only the media admin view.

๐Ÿ› Bug report
Status

Closed: outdated

Component

User interface

Created by

๐Ÿ‡บ๐Ÿ‡ธUnited States aaronpinero

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • ๐Ÿ‡ฆ๐Ÿ‡นAustria Grienauer Vienna

    I can reproduce it :)
    Scrollbar is missing, if the Area is too narrow, then vertical scrollbar is not really clickable.
    But I have also another view, where a lot of columns are, then the pagination is also not clickable.

    Added 2 Screenshots:
    โ†’
    โ†’

    it seems to be only on mac safari and not for another systemโ€ฆ and only if too much content is inside of the view/area horizontally.
    The margin bottom/overflow css behaves weird there.

  • ๐Ÿ‡ฆ๐Ÿ‡นAustria Grienauer Vienna
  • Assigned to rupeshghar
  • Issue was unassigned.
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia rupeshghar

    I am not able to reproduce it and it is working for me. @Grienauer May be you can share safari version and more detailed steps around it

  • ๐Ÿ‡ง๐Ÿ‡ชBelgium tcho

    I have the same problem with paragraph and .gin-table-scroll-wrapper (tested with firefox and chrome).

    If you remove the negative margin and padding, the problem is solved but I don't know if that have and another impact :

    margin-bottom: -240px;
    padding-bottom: 240px;
  • ๐Ÿ‡ง๐Ÿ‡ชBelgium tcho

    I have add a patch (gin version 8.x-3.0-rc5).
    That resolve the problem but I don't know the impact for other features.

    Someone can be test the patch ?

  • Status changed to Closed: outdated 4 months ago
  • ๐Ÿ‡จ๐Ÿ‡ญSwitzerland saschaeggi Zurich

    Closing as outdated, as this code has been refactored in the meantime.

Production build 0.71.5 2024