Automatically closed - issue fixed for 2 weeks with no activity.
More or less everywhere we take an array of $messages
as a method argument, we pass it not only not only TranslatableMarkup[]
, in practice, but also string[]
this seem to happen most in in tests. The other case where we do this is when add validation results from exceptions.
We don't add want developers to create validation results that are not translatable. The only time where this should happen is when validation results are being create from throwable. in that case they won't be translatable.
We should make it easy to make it obvious that all validation results should translatable exception when created from exceptions
\Drupal\package_manager\Event\PreOperationStageEvent::addErrorFromThrowable
\Drupal\package_manager\ValidationResult::createErrorFromThrowable
\Drupal\package_manager\ValidationResult::createError or \Drupal\package_manager\ValidationResult::createWarning, \Drupal\package_manager\Event\PreOperationStageEvent::addError or \Drupal\package_manager\Event\StatusCheckEvent::addWarning
\Drupal\package_manager\Event\PreOperationStageEvent::addErrorFromThrowable
1,2,3 are done. 4 and 5 need to be done
Fixed
2.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Automatically closed - issue fixed for 2 weeks with no activity.