[policy, no patch] Backport policy for Starterkit theme changes

Created on 23 September 2022, almost 3 years ago
Updated 23 April 2025, 3 months ago

Problem/Motivation

The current backport policy only allows changing CSS, markup, or template changes in a minor. This doesn't take into account that Starterkit theme CSS, markup, and templates are not something sites rely on runtime.

Proposed resolution

Change the backport policy to allow backporting CSS, markup, and template changes that are required for fixing bugs in the Starterkit theme. New features and code refactoring are not backported to patch releases.

📌 Task
Status

Needs review

Version

11.0 🔥

Component

Starterkit theme

Created by

🇫🇮Finland lauriii Finland

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇳🇿New Zealand quietone

    The allowed changes for minor releases does list CSS, markup, or template changes (except for stable base themes) for minor releases. However, the allowed changes for patch releases states that "non-disruptive bug fixes" are allowed. So, the fixes described in the issue summary would fit within the existing criteria.

    An extra sentence could be added to explain that changes to Starterkit are not disruptive. However, Disruptive is defined later in the document and can be evaluated in any issue or amongst the core committers. Also, there is always tension in such documents to provide both detail and flexibility in interpretation. I would rather leave the policy as is.

  • 🇺🇸United States smustgrave

    I think the policy works as is. Know it comes up often about wanting to make twig changes on themes and usually we can re-work that solution to not include twig tweaks.

    Maybe worth exploring deprecation solutions within twig? Like

    If on 10.3 this is the old that will break in the future, use 11.x way.

    idk if that makes any sense but marking RTBC that think leaving it is fine.

  • 🇬🇧United Kingdom catch

    This needs a proposed wording and link to the policy being changed.

  • 🇳🇿New Zealand quietone

    As stated in #4, I don't think any change to any existing policy is needed. I will try to make it clearer.

    The backport policy states

    Most patches that are allowed in patch releases can be cherry-picked between minor versions. Committer apply these patches to both branches at the same time.

    The allowed changes policy lists what can be applied in patch fixed and that includes

    non-disruptive bug fixes

    . Since, the changes to Starterkit theme CSS, markup, and templates are non-disruptive, they are already covered. Therefore, there is no need to update policy.

    Restoring RTBC since I've only added more explanation and updated the IS.

  • 🇬🇧United Kingdom catch

    Ahh sorry, that makes sense! Moving this to fixed then.

  • 🇳🇿New Zealand quietone

    No worries. Glad this is resolved.

  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Status changed to Fixed 15 days ago
  • 🇳🇿New Zealand quietone

    Changing to latest version when this was closed.

Production build 0.71.5 2024