Make CDN loading or local loading a setting instead of auto-detection

Created on 23 September 2022, about 2 years ago
Updated 31 July 2023, over 1 year ago

Problem/Motivation

Currently photoswipe falls back to CDN if the local photoswipe library is not present. This is too dangerous in cases of GDPR and should be a decision of the site owner.

The administrator should decide on the photoswipe settings page, where to load the libraries from. This MAY default to CDN to keep the current implementation, but make it exposed.

If the local library is not available, that option should still be available but with a warning on the page, that Photoswipe will not work properly if the library can not be loaded and a warning message in the status report.

If CDN is selected, we should assume that it's available.

Steps to reproduce

Proposed resolution

Add a separate status info to the status page for "Photoswipe library", sth. like:

  • Local library used, Local library found (green)
  • Local library used, Local library missing (red)
  • CDN used, Local library found (green)
  • CDN used, Local library not present (green)

Add the proposed setting on the settings page
Add tests to ensure this works as expected and never loads from CDN if local is selected

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Closed: works as designed

Version

5.0

Component

Code

Created by

🇩🇪Germany Anybody Porta Westfalica

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024