Media Library views fail to reset pager when filters are applied

Open on Drupal.org →

Created on 8 September 2022, about 2 years ago

Updated 16 April 2024, 7 months ago

Problem/Motivation

When interacting with exposed filters in the Media Library you can get "no results" even when there are valid results, just because the pager does not get reset.

Steps to reproduce

Set up a site with the Media Library module enabled and configured for a text format. The Umami demo works great for this.
Create enough media items such that they will overflow onto more than one page of results in the media embed modal.
Open the media embed modal from a rich text area and page to "page 2" of media results.
Search for text that appears only in a small subset of your media items (a small enough subset such that the result set is smaller than one page of results).
You'll receive the message "No media available." despite the fact that there is, in fact, media that matches your search term.

This happens because the view still has you on page 2 of the results, and there aren't enough results to flow onto a second page. The pager doesn't even display to give you a clue that this has happened.

Proposed resolution

Reset the pager any time the user interacts with the exposed filters.

🐛 Bug report

Status

Closed: duplicate

Version

11.0 🔥

Component

Last updated 42 minutes ago

Maintained by
🇳🇱Netherlands @seanB
🇩🇪Germany @chr.fritsch
🇺🇸United States @phenaproxima
🇪🇸Spain @marcoscano

Created by

🇺🇸United States azinck

Live updates comments and jobs are added and updated live.

Needs Review Queue Initiative
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Incomplete comments

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment about 1 year ago →
🇺🇸United States Kasey_MK
Thanks azinck this has been a frustrating little problem, and how nice that your simple fix just works and makes the problem go away!
Comment 12 months ago →
🇺🇸United States DamienMcKenna NH, USA
Is this the same as 🐛 Media Library widget display doesn't return to first page on applying filters Needs work ?
Comment 10 months ago →
🇺🇸United States Kasey_MK
Yes @DamienMcKenna I believe so.
Comment 7 months ago →
codebymikey
Status changed to Closed: duplicate 7 months ago3:14pm 9 April 2024
Comment 7 months ago →
🇬🇧United Kingdom alexpott 🇪🇺🌍
This is a duplicate of 🐛 Media Library widget display doesn't return to first page on applying filters Needs work going to close this one and move credit over there.

Also I think 🐛 Pagination not working correctly in AJAX view with exposed filters Needs review is an alternate and maybe additional fix that would be good but we could do both together.
Comment 7 months ago →
🇬🇧United Kingdom catch
Just to add it may also be a duplicate of 🐛 MediaLibraryState passes all query parameters around, not just the ones it needs Active .

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024