- π¬π§United Kingdom rachel_norfolk UK
MR migrated to GitHub - see https://github.com/simplytestme/website/pull/350
- Status changed to RTBC
11 months ago 5:03pm 9 February 2024 - π¬π§United Kingdom rachel_norfolk UK
So, with the PR (!) applied, the project browser does run. It is giving sensible composer commands to install, etc etc.
- Status changed to Needs work
11 months ago 5:33pm 9 February 2024 - π¬π§United Kingdom rachel_norfolk UK
I am an idiot and didnβt run the unit tests! They need work...
- π¬π§United Kingdom rachel_norfolk UK
Updated the tests pretty much according to the revised configuration BUT Iβm not happy with simply changing the php memory limit to 512M. It seems wildly excessive for just one module???
- πΊπΈUnited States mglaman WI, USA
I think it's fine to just bump to 512MB. Project Browser does some expensive stuff and I don't think it has been optimized yet. I'm not sure our normal memory limit. But it's not like it'll always be consuming 512MB. Bumping it higher may also allow better testing of modules like Feeds.
Looks like the default used to be 256 https://git.drupalcode.org/search?search=memory_limit&nav_source=navbar&... I don't know if this is our current.
Does Project Browser require 512 or would 256 work?
- π¬π§United Kingdom rachel_norfolk UK
Good question on what the actual requirement is. I just noted 512M in the original MR. Will inquireβ¦
- πΊπΈUnited States chrisfromredfin Portland, Maine
Hi all -
Just wanted to point out that you seem to be talking about PHP `memory_limit,` but this issue is actually related to MySQL `max_allowed_packet` - how big of a packet you can inject in, say, an INSERT statement.
We are using very large insert statements in our install process, because we are populating a database table from a json fixture (fixtures/project_data.json). Note that this is temporary because this is our workable mock alternative to having an actual JSON:API endpoint live on a production Drupal 10 instance.
33554432 is ~32MB, and probably would work. With that said, I should point out that this fix never actually worked to make Project Browser installable in SimplyTest.me. (see comment #9 - https://www.drupal.org/project/simplytest/issues/3308702#comment-14838997 β - above)
- π¬π§United Kingdom rachel_norfolk UK
Hi Chris - the change includes both right now - a new max_allowed_packet and a PHP memory size. I have no problem with the max_allowed_packet. I'm just querying the PHP memory size change.
See https://github.com/simplytestme/website/pull/350/files#diff-188015a49750... for reference.
- πΊπΈUnited States chrisfromredfin Portland, Maine
Oh, wonderful! I missed that. So to that I can say I don't anticipate we need 512, I believe 256 should be adequate *for us* anyway. :)
- πΊπΈUnited States chrisfromredfin Portland, Maine
Coming back to reference https://www.drupal.org/project/project_browser/issues/3420698#comment-15... π PHP memory requirements to install in simplytest.me seem excessive? Fixed - in that I tested and could get it down as far as 192 if that mattered. Looks like we've already discussed 256 also. I am going to close the related issue in Project Browser since that was to get this answer. :)