Contrib.social

Allow overriding text for frontpage plugins

Open on Drupal.org →
Created on 7 September 2022, over 2 years ago
Updated 7 August 2024, 8 months ago

Problem/Motivation

I need to replace the default pattern for the frontpage plugin (site name based) by a simple "Home", and I had to make a custom plugin, we might as well provide a "text override property" so this task is easier.

Steps to reproduce

Add a Frontpage plugin, the text cannot be overriden.

Proposed resolution

Add a simple textfield to allow overriding the text for the home link.

Remaining tasks

Patch incoming.

✨ Feature request
Status

Needs work

Version

2.0

Component

Code

Created by

🇪🇸Spain pcambra Asturies

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment about 1 year ago →
    🇨🇦Canada mparker17 UTC-4

    This sounds more like a feature request than a task, so I'm updating the category.

    (I'm cleaning up old issues as part of a big review of open issues for 🌱 [Plan] Stable 8.x-2.0 release Active : thank you for your patience with me)

  • Status changed to Needs work 8 months ago
  • Comment 8 months ago →
    🇨🇦Canada mparker17 UTC-4

    @pcambra, thank you for the contribution; and thank you for your patience with me (I've had a very busy 5 months!)

    This looks like a good start, but I am not ready to merge it for two reasons:

    1. it doesn't have any tests, and we need tests so that future changes to the sitemap module don't break your website
    2. I'd prefer the machine name front_text_override instead of text_override (i.e.: because it makes this setting's relationship to the front-page-plugin clearer)

    If you have the time to work on this issue, may I trouble you to make these changes, and then move this ticket back to "Needs review"? If you don't have the time to work on this issue, please let us know so that someone else can pick it up!

    If you need some help writing tests, please ask in this thread, and I'll see what I can do to help.

    Thank you very much!

  • Comment 8 months ago →
    🇨🇦Canada mparker17 UTC-4

    Adding "Needs tests" tag.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024