Form API change from 1.x to 2.x is undocumented

Created on 25 August 2022, over 2 years ago
Updated 24 March 2023, almost 2 years ago

Problem/Motivation

The form api integration for the module changed the required attribute field name from 'maxlength' to 'data-maxlength'

Steps to reproduce

Upgrade maxlength module to any 2.0 on a site with existing forms.

Proposed resolution

Add note of change to readme file or update documentation.

I am reporting this here so any other users that have come across this issue may find this report useful.

Remaining tasks

  • ✅ Get maintainer approval for the proposed resolution
  • ✅ Implement resolution
  • ✅ Write test coverage (contact a maintainer if you need help)
  • ✅ Maintainer review via the UI
  • ❌ Maintainer Code Review #1
  • ❌ Maintainer code review #2
  • ❌ Merge into dev branch, with credit to author and participants
Feature request
Status

Needs review

Version

2.1

Component

Documentation

Created by

Live updates comments and jobs are added and updated live.
  • Documentation

    Primarily changes documentation, not code. For Drupal core issues, select the Documentation component instead of using this tag. In general, component selection is preferred over tag selection.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024