- πΊπΈUnited States mlncn Minneapolis, MN, USA
Looks good just one more change compared to π Automated Drupal 10 compatibility fixes Fixed
- Status changed to Fixed
almost 2 years ago 5:57pm 31 January 2023 Add D10 compatibility for block visibility groups admin submodule
- Status changed to Needs review
almost 2 years ago 11:41pm 3 February 2023 - Status changed to Needs work
almost 2 years ago 6:06am 4 February 2023 - π―π΅Japan ptmkenny
Bumping to Critical because the module is marked as D10 compatible but actually the Admin submodule cannot be installed without this fix.
After applying #7, enabling the Admin submodule, and going to /admin/structure/block, I get a WSOD:
Symfony\Component\Routing\Exception\RouteNotFoundException: Route "entity.block_visibility_group.add_form" does not exist. in Drupal\Core\Routing\RouteProvider->getRouteByName() (line 206 of core/lib/Drupal/Core/Routing/RouteProvider.php). Drupal\Core\Routing\UrlGenerator->getRoute('entity.block_visibility_group.add_form') (Line: 270) Drupal\Core\Routing\UrlGenerator->generateFromRoute('entity.block_visibility_group.add_form', Array, Array, 1) (Line: 105) Drupal\Core\Render\MetadataBubblingUrlGenerator->generateFromRoute('entity.block_visibility_group.add_form', Array, Array, 1) (Line: 765) Drupal\Core\Url->toString(1) (Line: 182) Drupal\Core\Utility\LinkGenerator->generate(Object, Object) (Line: 95) Drupal\Core\Render\Element\Link::preRenderLink(Array) call_user_func_array(Array, Array) (Line: 101) Drupal\Core\Render\Renderer->doTrustedCallback(Array, Array, 'Render #pre_render callbacks must be methods of a class that implements \Drupal\Core\Security\TrustedCallbackInterface or be an anonymous function. The callback was %s. See https://www.drupal.org/node/2966725', 'exception', 'Drupal\Core\Render\Element\RenderCallbackInterface') (Line: 788) Drupal\Core\Render\Renderer->doCallback('#pre_render', Array, Array) (Line: 374) Drupal\Core\Render\Renderer->doRender(Array) (Line: 446) Drupal\Core\Render\Renderer->doRender(Array) (Line: 446) Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 204) Drupal\Core\Render\Renderer->render(Array, ) (Line: 238) Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}() (Line: 580) Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 231) Drupal\Core\Render\MainContent\HtmlRenderer->prepare(Array, Object, Object) (Line: 128) Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse(Array, Object, Object) (Line: 90) Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray(Object, 'kernel.view', Object) call_user_func(Array, Object, 'kernel.view', Object) (Line: 111) Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch(Object, 'kernel.view') (Line: 168) Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 74) Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58) Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48) Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106) Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85) Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48) Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51) Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 51) Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 680) Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
- Status changed to RTBC
almost 2 years ago 6:12am 4 February 2023 -
mlncn β
committed 7503135c on 2.0.x authored by
lelkneralfaro β
Issue #3303979 by lelkneralfaro, mlncn: Automated Drupal 10...
-
mlncn β
committed 7503135c on 2.0.x authored by
lelkneralfaro β
- Status changed to Fixed
almost 2 years ago 4:21am 10 February 2023 - πΊπΈUnited States mlncn Minneapolis, MN, USA
Fixed for the second time!
And a new release, https://www.drupal.org/project/block_visibility_groups/releases/2.0.1 β
Automatically closed - issue fixed for 2 weeks with no activity.