- 🇨🇳China skyredwang Shanghai
A block could be missing, but also the references in the block can also be missing.
/** @var \Drupal\Core\Entity\EntityInterface $reference */ /** @var \Drupal\Core\Entity\EntityInterface $reference_clone */ $reference = \Drupal::service('entity_type.manager')->getStorage($target_type)->load($value['target_id']);\ $reference_clone = $reference->createDuplicate();
These two lines need a null check.
- Status changed to Needs review
over 1 year ago 10:41am 3 August 2023 - last update
over 1 year ago 3 pass - 🇧🇷Brazil elber Brazil
@skyredwang I added basics null check, but I don't understand your entire idea please can you give me details about it?
- last update
8 months ago 2 pass, 1 fail - 🇪🇸Spain fjmurillo
Good morning,
Reviewing #6 i think that using the PHPUnit framework and its isNull method is not the best solution.
I am attaching a new patch that checks if the reference is an instance of ContentEntityInterface. The last submitted patch, 7: 3303254-7.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- last update
8 months ago 2 pass, 1 fail - last update
8 months ago 3 pass - last update
8 months ago 2 pass, 1 fail - Assigned to priyanka_chauhan31
- Issue was unassigned.
- Status changed to Needs review
7 months ago 2:17pm 10 April 2024 - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.1 & MariaDB 10.3.22last update
7 months ago Waiting for branch to pass - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.1 & MariaDB 10.3.22last update
6 months ago Waiting for branch to pass - last update
5 months ago 3 pass