- First commit to issue fork.
- π΅π±Poland dlevchik Poznan, Poland
- Merged 3.x into MR
- Added config option for 'Show alerts count'
- Added translation for @current_count of @total_count alerts
- Fixed db queries in a preprocess loop for total count by static caching it
- Added JS function updateAlertCount on initAlerts and removeAlert. Message is dynamic and translatable - π΅π±Poland dlevchik Poznan, Poland
- πΊπΈUnited States smustgrave
Nice, lets add some test coverage for this.
- π΅π±Poland dlevchik Poznan, Poland
Added tests, it is a FunctionalJavascriptTest. I wanted to test the alerts count change on adding new alert and dismissing another alert, and it kinda become also a test for sitewide_alert_block and refresh_interval. Hope you don't mind such a big test. Besides, there was no test cases for those things before, so it may be to the benefit
Also, a question maybe we may think of: should we hide alerts count when there is only one alert available for user? This also needs to be done via JS I believe, since dismissed alerts are in localStorage