- 🇩🇪Germany Anybody Porta Westfalica
I think this won't do any harm and is a possible workaround for issues like ✨ Allow coupons added to order (when not in draft) to apply the corresponding promotion Active
So setting this RTBC code-wise, if the maintainers have no objections.
- 🇩🇪Germany Anybody Porta Westfalica
@plopesc could you maybe update the MR to go into 3.x? I don't have permissions...
- 🇩🇪Germany Anybody Porta Westfalica
@jsacksick confirmed here ✨ Allow coupons added to order (when not in draft) to apply the corresponding promotion Active that he's willing to merge this, once ready for 3.x!
- 🇪🇸Spain plopesc Valladolid
Hi @anybody @jsacksick.
Created a new branch for 3.0.x where I cherry-picked the commit in the MR above and worked as expected.
However, I'm getting a 404 error when trying t access to the URL to generate the MR. https://git.drupalcode.org/issue/commerce-3303111/-/merge_requests/new?m...
You can checkout the branch locally and merge it if needed.
Diff can be checked in https://git.drupalcode.org/issue/commerce-3303111/-/compare/3.0.x...3303...
Thank you!
- 🇮🇱Israel jsacksick
Hi plopesc, you're usually getting a 404 if you're not logged in into Gitlab.
- Merge request !362Issue #3303111: Make Coupons order field configurable → (Merged) created by plopesc
- 🇪🇸Spain plopesc Valladolid
Good catch! SSO failed for any reason and I was not logged in into Gitlab, while I was in d.o.
MR is not ready for review.
Automatically closed - issue fixed for 2 weeks with no activity.