Possible changes needed after #1014086 (10.1.x)

Created on 10 August 2022, almost 2 years ago
Updated 18 September 2023, 9 months ago

Problem/Motivation

After 11 years, 🐛 Stampedes and cold cache performance issues with css/js aggregation Fixed just got committed to Drupal 10.1.x.

Most of the details are in the change records: https://www.drupal.org/node/2888767 https://www.drupal.org/node/3301716

There are broadly two things to check regarding this for advagg I think:

1. It's possible that either the API changes in that issue or the logic changes (mostly around AssetResolver and CssCollectionOptimizer/JsCollectionOptimizer) will cause regressions in advagg. Needs confirming either way.

2. Core now generates CSS/JS aggregates on-demand in their own request, and there will likely be more changes coming in now that this has been implemented, such as 📌 Dynamically determine ajaxPageState based on libraries Active . It may be possible for advagg to rely on the core logic now that it's more efficient, and replace slightly less functionality than it currently does.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Closed: duplicate

Version

5.0

Component

Code

Created by

🇬🇧United Kingdom catch

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.69.0 2024