- First commit to issue fork.
- Merge request !7Issue #3301846: Not properly working with Google maps provider → (Closed) created by dieterholvoet
- 🇧🇪Belgium dieterholvoet Brussels
I created a MR based on the last patch and fixed an issue where results were not being returned in the correct language. Everything else seems to be working fine.
- 🇧🇪Belgium dieterholvoet Brussels
I also changed the types filter to allow searching for parts of addresses like just the city, instead of having to search for full addresses.
- 🇫🇷France GuillaumeDuveau Toulouse
Doesn't work for me. With and without the patch, no requests are made.
- 🇷🇸Serbia vaish
This patch incorporates the following:
- patch by chrisolof from #10
- commit 78502842 from merge request !7: Fix results not being returned in the correct language
- updated dependencies in libraries.yml to bring in compatibility with Drupal 10: Use
core/once
instead ofcore/jquery.once
Patch is compatible with both Drupal 9.5 and 10.1. If you want to use it with Drupal 10 you will also need #3349849-12: Drupal 10 compatibility → .
I decided not to push my updates to the existing merge request !7 because, I wanted to exclude two commits related to "Filter to full addresses or parts of addresses". In my opinion behavior introduced by those two commits may not match user expectations. When you start typing into the Street address field what you are entering is part of the street name. However, with the commits I excluded, results returned at first include only matching city names, not a single matching street name. Only after you type at least a whole word or more you start seeing street matches. I can image that this can be desired in certain use cases but I don't think it should be default module behavior. Perhaps this could be added as an additional feature in a separate issue.
This patch incorporates the following:
- patch by vaish from #17
- exposes the following routes, taking them out of the admin. This allows anonymous users to use this autocomplete field.
- address_autocomplete.addresses
- address_autocomplete.address_details
Updated patch after finding a path to one of the routes I updated had been hardcoded.
- 🇷🇸Serbia vaish
Merge request !11 created from the patch in #17. I've been using this patch in production for very long time.
@Blush I didn't include your changes from #19 because I didn't experience any issues with anonymous users not being able to use address autocomplete. If you still think there is a problem, please test the new release of the module which will be created soon and create new issue with steps how to reproduce it. Thanks.
- Status changed to Fixed
4 months ago 11:08am 22 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.