- 🇩🇪Germany Anybody Porta Westfalica
@Grevil: Would it make sense that Leon solves some of the tasks here for you to review?
This task lists relevant code cleanup requirements for the 5.x refactoring.
- [] Remove the term "node" from variables and labels, as Drupal 8+ is "entity"-based.
- [] Review all labels and settings, are they clear?
- [] Discuss to remove the field selection for captions and use only tokens instead:
as it's complex and rendering of the fields is broken. Token is more flexible and well tested. (From:
#3218673: Fix photoswipe_caption "entity_label" (legacy title: "node_title") →
)
- [] Use clear variable names for parent entity vs. image / media entity "$item->entity is not the same as $item->getEntity() which is quite confusing to be fair." (see
https://www.drupal.org/project/photoswipe/issues/3226541#comment-14636819 →
for details)
- [] Review / rewrite README.md to be correct and easy to understand.
- []
✨
[5.x] Separate image and entity_reference formatters
Needs work
- [] Remove "$instance->includeHidden" from "PhotoswipeFieldFormatter" and refactor how it is used, because as of
#3277884: Implement 'hide' option for photoswipe_node_style in responsive formatter →
this option is not used anymore.
- [] Remove hard-coded photoswipe-gallery wrapper (as we did in D7):
✨
[5.x] Add gallery grouping settings
Needs work
...?
Needs work
5.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
@Grevil: Would it make sense that Leon solves some of the tasks here for you to review?