Throws Notice on Login when destination is set

Can we get this committed and released? :-) RTBC+1

Easily reproduced the error putting a destination on link to a form. Patch in #18 solved the problem. RTBC +1

#18 work for me,
php 8.1
drupal 9.5.9
autologout 8.x-1.4
THX

@alberto56 recently launched the great little module ULI Custom Workflow → which creates a more 🐛 Friendly response to logged-in user landing on user/reset Active .

As a side effect, it looks like it also fixes this issue.

The patch in comment #18 has test errors. I don't think we can use it.

The last submitted patch, 18: 3301642-10.patch, failed testing. View results →

The patch in comment #18 has failing tests.

Here is a patch version of the the MR in comment #12 by mpaulo. I believe all tests are passing for it.

I tested on my local and the warning messages that appear when saving a new field no longer appear which was my use-case.

Two of the migration errors from the patch in comment #18 and #27 seem to stem from core:

🌱 [META] Serialization issues in Migration tests Active

I guess we can use the patch in #18 until the core issue is resolved.

I tried adding use DependencySerializationTrait; to the migration tests but still got the same errors.

This issue seems to be a duplicate, but with a much cleaner fix ... https://www.drupal.org/project/autologout/issues/3372010 🐛 Warning: Undefined array key 1 in Drupal\autologout\EventSubscriber\AutologoutSubscriber->onRequest() Needs work

🐛 Warning: Undefined array key 1 in Drupal\autologout\EventSubscriber\AutologoutSubscriber->onRequest() Needs work is already rtbc, while this is needs work. Closing this as a dupe of the other.