Add setting to only opt-in selected media bundles

Created on 1 August 2022, over 2 years ago
Updated 3 September 2024, 7 months ago

Problem/Motivation

As a simple first step towards #3271249: Only handle known providers (whitelist) and exclude others it would be helpful to add a setting to the settings page (admin/config/media/media-duplicates) to include / exclude certain media types (not) to be handled by this module.

This is especially helpful for the listing of duplicate media, which can't be properly detected by this module if a media type uses an unknown handler.
But I think even when the handler whitelist is implemented, this will be a helpful setting. By default, all media types should be handled, if the setting is not changed, so perhaps an exclusion makes more sense than an inclusion.

This should also include the entity list shown at "Rebuild", where the exclusions should not be listed, but perhaps a link to the settings page could be added to configure the exclusions.
The list at admin/config/media/media-duplicates/refresh should NOT become a duplicate with worse UX. It should either be removed or just show the subset of all allowed types from the settings page!

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Feature request
Status

Active

Version

2.0

Component

Code

Created by

🇩🇪Germany Anybody Porta Westfalica

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • @grevil opened merge request.
  • 🇩🇪Germany Grevil

    I feel like the table approach is a bit too much, as it takes a lot of space for a single setting. I feel like the better approach would be, to use a multiselect here, but @Anybody should decide.

  • Status changed to Postponed almost 2 years ago
  • 🇩🇪Germany Anybody Porta Westfalica

    Postponed on #3271249: Only handle known providers (whitelist) and exclude others which should definitely be solved first. In general I think the settings and rebuild concept should be overthought before.

  • 🇩🇪Germany Anybody Porta Westfalica
  • 🇩🇪Germany Grevil

    Note, that the rebuild checksum is only needed, if entities exist BEFORE the installation of this module. If the module is already installed, newly added duplicates will get automatically tracked on the reports page.

  • 🇩🇪Germany Grevil

    To properly handle this, my suggestion would be to exclude specified media types on the lowest level of the module inside "ChecksumStatistics". This is the main class used for checksum related database queries, where duplicate checksums, checksum existence, number of missing checksums, etc. is being checked. I'd say, we exclude the media types inside the queries there.

  • 🇩🇪Germany Anybody Porta Westfalica
  • 🇩🇪Germany Anybody Porta Westfalica

    Just turned around the title.

    We should add a setting to only include the selected media types. If none is selected (default) all media types are checked!

  • Assigned to Grevil
  • Status changed to Active 7 months ago
  • 🇩🇪Germany Anybody Porta Westfalica

    @grevil: We have this case now. Could you finish this, like described in #13 please? Feel free to delegate to LRwebks, if it makes sense. Basic work has already been done, but needs turn-around and finishing.

Production build 0.71.5 2024