- 🇩🇪Germany Anybody Porta Westfalica
@thomas.frobieter still relevant for 4.x or already solved in the meantime?
- Status changed to Needs work
10 months ago 9:58am 26 April 2024
Currently the media bundles stylesheets are located in our base theme (drowl_base_theme).
Instead we should define seperate libraries per bundle and add the stylesheets there.
Like we should do in all our module stylesheets, we should ensure that:
- We use CSS variables over SCSS variables, so themers can easily change colors etc.
- We don't rely on existing drowl_base_theme variables, we should always define variables with fallback values for this module (some on a module scope, some on bundle scope):
/* Module scope */
.media{
--dm-primary-color: var(--primary-color, #ff0000);
}
/* Bundle scope */
.media-slide{
--dm-slide-overlay-background: var(--dm-primary-color, #ff0000);
}
Needs work
4.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
@thomas.frobieter still relevant for 4.x or already solved in the meantime?