- π³πΏNew Zealand xurizaemon Εtepoti, Aotearoa π
This module's "printable_pdf" module depends on "pdf_api" module.
Relates to π D10 compatibility for PDF API Fixed .
- Status changed to Active
almost 2 years ago 3:48am 16 February 2023 - π³πΏNew Zealand xurizaemon Εtepoti, Aotearoa π
Putting this back to Active since it was RTBC'd for an earlier patch in #8. Will kick off tests next.
- @xurizaemon opened merge request.
-
Nigel Cunningham β
committed 43c446bd on 2.x
Issue #3297887: Drupal 10 compatibility fixes, partially automated....
-
Nigel Cunningham β
committed 43c446bd on 2.x
-
xurizaemon β
committed 2522b531 on 2.x
Issue #3297887: Fixes for PrintableUninstallTest and PrintablePdfTest
-
xurizaemon β
committed 2522b531 on 2.x
-
xurizaemon β
committed 0df02921 on 2.x
Issue #3297887: Relax constraints on wa72/htmlpagedom
-
xurizaemon β
committed 0df02921 on 2.x
- π¦πΊAustralia nigelcunningham Geelong
Merged! Thanks for all your work on this.
I'm working on updates to other modules at the moment but hope to get back to this soon.
- π³πΏNew Zealand xurizaemon Εtepoti, Aotearoa π
Thanks Nigel. A small action you might be able to do which can support progress while you're focused elsewhere - the automated test configuration for this module seems to be in an unworkable state.
It has probably auto-updated to Drupal 10 ("next dev release") with an old PHP version (7.4, not supported by 10.x), ref Drupal PHP requirements β .
All pipelines (unless manually customised) will report "Composer require failure" until this is addressed, I think.
Would you please visit Printable - Automated Testing β and select a valid configuration? And maybe for PDF API β too?
- π§πͺBelgium victonator
Can we get a tagged release with Drupal 10 support?
- πΊπΈUnited States markdorison
I created an issue today π Offering to co-maintain Printer and PDF Versions Fixed offering to be added as a co-maintainer to this module to assist in getting a D10 release shipped.
- π¦πΊAustralia nigelcunningham Geelong
@Victonator, sure. I'll just do some testing myself. Apologies that that hasn't happened quickly - I'm just too busy and the projects I work on aren't getting upgraded to D10 yet.
-
xurizaemon β
committed 0df02921 on 2.2.x
Issue #3297887: Relax constraints on wa72/htmlpagedom
-
xurizaemon β
committed 0df02921 on 2.2.x
-
xurizaemon β
committed 2522b531 on 2.2.x
Issue #3297887: Fixes for PrintableUninstallTest and PrintablePdfTest
-
xurizaemon β
committed 2522b531 on 2.2.x
- πΊπΈUnited States markdorison
@Nigel Cunningham The changes committed here drop support for Drupal 8. I could cut a new
3.x
branch to denote the breaking changes that are included before creating a beta release with D10 support. Would you be for or against that? - Status changed to Postponed
over 1 year ago 7:02pm 9 March 2023 - πΊπΈUnited States markdorison
Installation on D10 is currently blocked by the
drupal/pdf_api
dependency. Once a D10 release for that module has been created this will then be unblocked. π± [plan] New D10-compatible Release Fixed@Nigel Cunningham: feel free to add me as co-maintainer on pdf_api as well, if you would like my assistance. I will have the same question for you there about cutting a
3.x
branch/release. - π¦πΊAustralia nigelcunningham Geelong
I'm fine with dropping D8 support - it's not supported anymore by core. Will do pdf_api too.
Thanks!
- Status changed to Active
over 1 year ago 1:33am 12 March 2023 - Status changed to Fixed
over 1 year ago 2:26am 12 March 2023 - πΊπΈUnited States markdorison
3.0.0-rc1 has been tagged and released. Please create issues for any problems you encounter.
Automatically closed - issue fixed for 2 weeks with no activity.