Automated Drupal 10 compatibility fixes

There is a problem with symfony new implementation of $request->query->get() function.

In Drupal 10.0.2 with PHP 8.1.13 I get the following error message when opening a page with ?edit%5Btitle%5D%5Bwidget%5D%5B0%5D%5Bvalue%5D=Title

Symfony\Component\HttpKernel\Exception\BadRequestHttpException: Input value "edit" contains a non-scalar value. in Symfony\Component\HttpKernel\HttpKernel->handle() (line 81 of /var/www/html/vendor/symfony/http-kernel/HttpKernel.php).

In src/Populate.php L92

$this->request->getCurrentRequest()->query->get('edit');

produces an error in vendor/symfony/http-foundation/InputBag.php L36

if (null !== $value && $this !== $value && !\is_scalar($value) && !$value instanceof \Stringable) {

because it is an array. Proposed solution for this problem in patch file.

Can we roll #6 into the MR? And it would be nice to have test coverage of that feature.

Hi @heddn
sorry I don't understand what you mean with test coverage. Your existing tests will fail at the moment with

Testing /var/www/html/web/modules/custom/prepopulate/tests/src/Functional

Behat\Mink\Exception\ElementNotFoundException : Button with id|name|label|value "Save" not found.
 /var/www/html/web/core/tests/Drupal/Tests/WebAssert.php:144
 /var/www/html/web/core/tests/Drupal/Tests/UiHelperTrait.php:77
 /var/www/html/web/modules/custom/prepopulate/tests/src/Functional/PrepopulateFieldTest.php:111
 /var/www/html/web/modules/custom/prepopulate/tests/src/Functional/PrepopulateFieldTest.php:91
 /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

for example. Because you get an error page with no form and button. See this video https://www.loom.com/share/b46ec9da74c5481faf32f7d6f3ed3a8c

I couldn't get the test on drupal.org running because of the dependency on the inline_entity_form module. So despite that, I set the status to "Needs review"

I agreed with @mvogel's approach in #6. This was due to a change introduced in symfony 5.1: https://github.com/symfony/symfony/pull/34363
I've simplified it a bit by directly accessing 'edit' from query->all().
Agreed that it doesn't need tests as every single other test will fail on symfony/http-foundation >= 5.1 (i.e. Drupal 10) - i.e. it's already covered by other tests.

I've also added return values for all tests.

I've pushed to the MR, also attaching a patch for patching via composer.

The test runs against D10 will likely fail due to the core_version_requirement changes being in the MR/patch.

Previous tests failed, because the dev-dependencies are not stable yet. A composer.json file fixes this. D10.0.1 with PHP 7.4 cannot work because D10 requires minimum PHP 8.1

@sleitner thanks for that. I think this is ready.

Let's see if this code will also work for D9.5 as well or if we need to do some more adjustments to distinguish from 10.x

Thanks for all the work here everyone.

Automatically closed - issue fixed for 2 weeks with no activity.

Shouldn't the issue be left open so the Project Update Bot can submit new patches if needed?