Automated Drupal 10 compatibility fixes

Created on 18 July 2022, almost 2 years ago
Updated 31 May 2023, about 1 year ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects β†’

Periodically patches will be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted simply close this issue (any status besides Active, Needs review or Needs work) or remove the "ProjectUpdateBotD10" tag from the issue.

The patches will be posted by the Project Update Bot β†’ official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review or Needs work) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD10" tag from the issue.

    You can use Drupal Rector yourself to make these patches.

    If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review or Needs work) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the patch in the comment by Project Update Bot β†’ .
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot β†’ , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue β†’ . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Infrastructure project issue queue β†’ using the component β€œBot: Drupal Rector”.

πŸ“Œ Task
Status

Fixed

Version

3.0

Component

Code

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States mark_fullmer Tucson

    Checking in with the module maintainers: with this already committed to the 5.0.x branch, would it be possible to get a new release tagged so that sites can require this via the normal Composer methods? Thanks in advance!

  • πŸ‡ΊπŸ‡¦Ukraine podarok Ukraine

    You can add https://www.drupal.org/project/features/releases/5.0.x-dev β†’ release to composer and test @mark_fullmer

  • Any word on when a release will be made for Drupal 10 compliance? I've run the dev release and it seems to be working perfectly. Unfortunately due to security policies at the office we cannot run dev versions and need a stable release. This is one of the last modules we are waiting on to upgrade to Drupal 10 and would really appreciate a stable release when the maintainers get a chance.

  • Status changed to RTBC about 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States mark_fullmer Tucson

    I've run the dev release and it seems to be working perfectly. Unfortunately due to security policies at the office we cannot run dev versions and need a stable release. This is one of the last modules we are waiting on to upgrade to Drupal 10 and would really appreciate a stable release when the maintainers get a chance.

    +1 to all of this:

    - Our team has also tested the 5.0.x-dev branch with Drupal 10 and not encountered any issues
    - For policy reasons, we also cannot require branches of projects in our stable releases
    - This is also one of the last modules we are waiting on for the Drupal 10 upgrade

    Marking as RTBC to reflect two community members vouching that it is functionally compatible with D10.

  • πŸ‡ΊπŸ‡ΈUnited States gravelpot

    Hello, I'm here to add one more +1 in support of a D10-compatible release.

    An alpha or beta release would be fine, just something other than a dev build, since we have recently run into a technical limitation using a dev
    build based on a specific commit hash. We found that you can't rely on getting the same thing every time you do a Composer build without modifying the site's root `composer.json` file, which isn't an option for us with the architecture of our Pantheon custom upstream.

    We are on schedule to upgrade ~100 sites from D9 to D10 in May, and this is one of the last remaining contrib modules in our standard distribution that does not have a D10 compatible release. I appreciate all the fine work folks are doing here, and hope this can get pushed over the finish line soon. Please let us know if there is any further labor that can be contributed to the effort in specific issues.

  • πŸ‡ΊπŸ‡ΈUnited States mmarler

    Adding a +1 here too. My team will be upgrading sites to Drupal 10 on May 23rd, and would love to have a stable, Drupal 10 compatible release for the Features module. Thanks for all the work on this!

  • πŸ‡¨πŸ‡¦Canada nedjo

    Thanks for your notes. While I am currently the most active maintainer in Features for Drupal 9, I am not the project owner. I'm not planning to cut a D10 compatible stable release as I am transitioning out of Drupal and therefore won't be maintaining through the new release cycle. It may be time for some of the steps outlined in the documentation page Finding a new project owner or new maintainers/co-maintainers β†’ .

  • πŸ‡ΊπŸ‡ΈUnited States mark_fullmer Tucson

    Thanks for clarifying your current relationship to maintainership, nedjo, and thanks for all your work up till now.

    One potential win-win would be for you to go ahead and tag a Drupal 10-compatible release from what is current in the 5.0.x branch, and simultaneously mark the project as not actively supported. That would allow folks to composer-require a D10-compatible release and provide patches, as needed, in the short term, to fix any incompatibilities, while not creating an expectation that you provide maintenance during the Drupal 10 release cycle.

    Long term, of course, folks should step up to follow the steps in offering to co-maintain this project ( https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... β†’ ).

    But a tagged release would be very beneficial in un-blocking people using this site who are trying to update to Drupal 10.

  • πŸ‡¨πŸ‡¦Canada nedjo

    @mark_fuller, okay, I've gone ahead and created a 5.0.0-alpha1 release β†’ and linked to this conversation in the release notes. For now, releases in the 5.0.0 branch is marked supported but not recommended.

  • πŸ‡ΊπŸ‡ΈUnited States mark_fullmer Tucson

    Wonderful, @nedjo! The Drupal community thanks you. I'll talk with our team about what we can do to help maintain the Features module going forward.

  • Status changed to Fixed about 1 year ago
  • Automatically closed - issue fixed for 2 weeks with no activity.

  • First commit to issue fork.
  • πŸ‡ΊπŸ‡ΈUnited States Dave Reid Nebraska πŸ‡ΊπŸ‡Έ

    Do we know what the long-term roadmap is for the 5.x version is? There's currently a note on the https://www.drupal.org/project/features/releases/5.0.0-alpha1 β†’ release:

    Updating to releases on this branch is not yet recommended, pending confirmation of a plan for ongoing maintenance.

    Has this been addressed in any way? Is there a roadmap? Are there major changes we should be aware of in the 5.x branch either currently or incoming, or should this just be a stable release on the 3.x branch?

  • πŸ‡ΊπŸ‡ΈUnited States Dave Reid Nebraska πŸ‡ΊπŸ‡Έ

    I'm not really seeing any major differences between the 8.x-3.x branch and the 5.x branch aside from the Drupal 10 changes, would we be opposed to just merging this into 3.x and tagging a new stable release there?

  • πŸ‡ΊπŸ‡ΈUnited States Dave Reid Nebraska πŸ‡ΊπŸ‡Έ
  • πŸ‡ΊπŸ‡ΈUnited States Dave Reid Nebraska πŸ‡ΊπŸ‡Έ

    Just a heads up for everyone, we are talking about plans to merge the current 5.x branch into the 8.x-3.x branch and tag a stable release, and then probably get rid of the 5.x branch for now. I think it was only really used for this code and doesn't contain any major changes aside from keeping up to date with Drupal core major versions, so there's no reason for a separate branch really. Unless someone really needs a Drupal 8-only compatible branch, but Drupal 8 is unsupported right now anyway, so it's a moot point.

Production build 0.69.0 2024