Automated Drupal 10 compatibility fixes

As discussed, after the cleanup what's left here is fixing a single test that we previously didn't notice because when the already existing D10-compatible version was created as part of #3264928: Add support for Drupal 10 → , classy was still in core.

I left a comment about the changes there, feel free to either commit or make some changes first, it's pretty minor.

I did research and found that #2718381: Incorrect Breadcrumb for Markdown diff → added the extra breadcrumb asserts. But they aren't really needed so I've removed it to make the tests less brittle. The other item that slipped in since this was re-rolled is a change that seems to impact the trimming logic in DiffPluginTest. I got tests passing by altering the test. It seems to be still testing what it was before, but I'm not really sure why the line numbers are all off. A bit disconcerting so leaving this up for review for other's feedback.

Fine by me, but the tests didn't run as it's the wrong php version.

Default configurations should be updated, I do prefer to do patch testing on the lowest supported version and have a weekly d10 test. It's IMHO more likely to break d9 than d10 at this point

We have a situation where on D10, there are only 4 rows and in D9, there are 5 rows. What changed here?

No idea, assuming it can be reproduced locally, you need to run the test and dump the exact output you get and compare it, seems to be testing a very specific thing with empty lines, possibly the test tools we use changed?

I hunted and found that https://www.drupal.org/node/3299678 → is what is breaking things. The new diff engine used by core 10.1+ shows slightly different amounts of context data then prior to that commit. Let's fix that.

+1 if that comes back green.

Thanks everyone for your help and patience here. This is now landed and default CI test runner configuration adjusted to default to 9.5 on issue/commit and 10.1.x for weekly.

Automatically closed - issue fixed for 2 weeks with no activity.

This fix should go into a tagged release. I just hit this on the latest tagged release 1.1.0 from 2 years back

heddn → closed merge request !21