Contrib.social

Automated Drupal 10 compatibility fixes

Open on Drupal.org →
Created on 18 July 2022, almost 2 years ago
Updated 26 March 2024, 3 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects →

Periodically patches will be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted simply close this issue (any status besides Active, Needs review or Needs work) or remove the "ProjectUpdateBotD10" tag from the issue.

The patches will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review or Needs work) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD10" tag from the issue.

    You can use Drupal Rector yourself to make these patches.

    If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review or Needs work) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the patch in the comment by Project Update Bot → .
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Infrastructure project issue queue → using the component “Bot: Drupal Rector”.

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

Project Update Bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago →
    🇨🇭Switzerland Berdir Switzerland

    As discussed, after the cleanup what's left here is fixing a single test that we previously didn't notice because when the already existing D10-compatible version was created as part of #3264928: Add support for Drupal 10 → , classy was still in core.

    I left a comment about the changes there, feel free to either commit or make some changes first, it's pretty minor.

  • Comment over 1 year ago →
    heddn Nicaragua

    I did research and found that #2718381: Incorrect Breadcrumb for Markdown diff → added the extra breadcrumb asserts. But they aren't really needed so I've removed it to make the tests less brittle. The other item that slipped in since this was re-rolled is a change that seems to impact the trimming logic in DiffPluginTest. I got tests passing by altering the test. It seems to be still testing what it was before, but I'm not really sure why the line numbers are all off. A bit disconcerting so leaving this up for review for other's feedback.

  • Comment over 1 year ago →
    🇨🇭Switzerland Berdir Switzerland

    Fine by me, but the tests didn't run as it's the wrong php version.

    Default configurations should be updated, I do prefer to do patch testing on the lowest supported version and have a weekly d10 test. It's IMHO more likely to break d9 than d10 at this point

  • Comment over 1 year ago →
    heddn Nicaragua

    We have a situation where on D10, there are only 4 rows and in D9, there are 5 rows. What changed here?

  • Comment over 1 year ago →
    🇨🇭Switzerland Berdir Switzerland

    No idea, assuming it can be reproduced locally, you need to run the test and dump the exact output you get and compare it, seems to be testing a very specific thing with empty lines, possibly the test tools we use changed?

  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago →
    heddn Nicaragua

    I hunted and found that https://www.drupal.org/node/3299678 → is what is breaking things. The new diff engine used by core 10.1+ shows slightly different amounts of context data then prior to that commit. Let's fix that.

  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    heddn Nicaragua
  • Comment over 1 year ago →
    System Message
    • heddn → committed 0ff9ea08 on 8.x-1.x 
      Issue #3296959 by heddn, Berdir: Automated Drupal 10 compatibility fixes
  • Comment over 1 year ago →
    🇨🇭Switzerland Berdir Switzerland

    +1 if that comes back green.

  • Status changed to Fixed over 1 year ago
  • Comment over 1 year ago →
    heddn Nicaragua

    Thanks everyone for your help and patience here. This is now landed and default CI test runner configuration adjusted to default to 9.5 on issue/commit and 10.1.x for weekly.

  • Comment over 1 year ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

  • Status changed to Fixed 3 months ago
  • Comment 3 months ago →
    🇨🇦Canada joseph.olstad

    This fix should go into a tagged release. I just hit this on the latest tagged release 1.1.0 from 2 years back

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024