Contrib.social

Automated Drupal 10 compatibility fixes

Open on Drupal.org →
Created on 18 July 2022, over 2 years ago
Updated 27 November 2023, 12 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects →

Periodically patches will be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted simply close this issue (any status besides Active, Needs review or Needs work) or remove the "ProjectUpdateBotD10" tag from the issue.

The patches will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review or Needs work) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD10" tag from the issue.

    You can use Drupal Rector yourself to make these patches.

    If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review or Needs work) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the patch in the comment by Project Update Bot → .
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Infrastructure project issue queue → using the component “Bot: Drupal Rector”.

📌 Task
Status

Needs review

Version

1.0

Component

Code

Created by

Project Update Bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago →
    🇳🇱Netherlands arantxio Dordrecht

    I've looked at the report from upgrade status and added the fixes from there and the one that the update bot created and made a patch based on that.

    This should fix all the current problems.

  • Status changed to RTBC over 1 year ago
  • Comment over 1 year ago →
    🇮🇳India Bushra Shaikh

    I have reviewed and checked Patch #3, which works for Drupal 9.5 and Drupal 10.0. and 10.0.1
    Screenshots of the compatibility on 9.5 have been attached for reference:

  • First commit to issue fork.
  • Merge request !1Issue #3296943: Automated Drupal 10 compatibility fixes → (Open) created by mkdok
  • Comment about 1 year ago →
    🇧🇪Belgium stijnhau

    Any idea when this could be added?

  • Comment about 1 year ago →
    🇨🇿Czech Republic Bohus Ulrych Pilsen (Czechia)

    Hi all,
    I discovered that patch is drupal-10-readiness.patch is not good.
    Together with drupal-lenient it allows you to install this module (syntax is ok), but functional is broken.

    Problem is in the line replacing module_load_invoke, in the default_menu_link.module
    \Drupal::moduleHandler()->loadInclude($pathInfo['extension'], $moduleName, $directory . '/' . $pathInfo['filename']);
    is wrong, it should be
    \Drupal::moduleHandler()->loadInclude($moduleName, $pathInfo['extension'], $directory . '/' . $pathInfo['filename']);

    After this change it works well with 10.1.5

  • Status changed to Needs work 12 months ago
  • Comment 12 months ago →
    🇮🇩Indonesia gausarts

    I am not the maintainer, but my clients would love this in.

    Let's trigger the bot again as per #8, while waiting for the maintainers to respond to this.

    Thank you.

  • Status changed to Needs review 12 months ago
  • Comment 12 months ago →
    🇳🇱Netherlands arantxio Dordrecht

    I've adjusted the MR with the changes suggested by @Bohus Ulrych. Thanks for checking it out.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024