Automated Drupal 10 compatibility fixes

Hi Team, I have Port this Theme in drupal 9 and drupal 10 versions please check and review the code and apply the patch on the Drupal 10 setup.
Step to Find the Error on Drupal 10 Version
1. Drupal check command use to check the error.
COMMAND: vendor/mglaman/drupal-check/drupal-check themes/danland/

Fixed Website encounter issue. Added patch again.

Verified and tested Patch Comment #18 on drupal 10.1.x "warning: 1 line adds whitespace errors."

Testing Steps:-
1. Install drupal 10.1.x version.
2. git clone branch '8.x-1.x' danland.git
2. Applied Patch #18 /projects/drupal/themes/contrib/danland
3. Checked the changes difference using git diff
4. Installed theme and set it as default.

Testing result:
Danland Theme compatible with drupal 10.1.x
Here I have attached the screenshots.

Fix Drupal coding standards.

Fixed "warning: 1 line adds whitespace errors" Please review again.

Thanks Akshay,
Patch Applied cleanly.
Fixed Drupal coding standards. "warning: 1 line adds whitespace errors" Warning removed.
Here I have attached the screenshots.

1. +++ b/danland.info.yml
   @@ -1,8 +1,8 @@
   -base theme: classy
   +base theme: claro
   

   Base should not be Claro

2. +++ b/danland.info.yml
   @@ -1,8 +1,8 @@
   -core_version_requirement: ^8.8 || ^9
   +core_version_requirement: '^8 || ^9 || ^10'
   

   The file_url_generator used below requires Drupal 9.3

@jcnventura so can we select the base theme or use stble9.

I have created a patch to remove the base theme as claro and set the base theme to stable9
and change the core_version_requirement: ' ^9.3 || ^10' This theme will be compatible with Drupal 9.3 above and Drupal 10.

A question before this patch is merged:

Shouldn't we need a composer.json in this project?
I know, it isn't strictly needed because this theme doesn't need any other "requirements" but it should be convenient for composer to work more smoothly. Especially to find out if this is a module or a theme. It can find this info under the "type" tag.
I have made sample that could be used:

{
  "name": "drupal/danland",
  "type": "drupal-theme",
  "description": "Provides Danland theme",
  "keywords": ["Drupal"],
  "license": "GPL-2.0+",
  "homepage": "https://www.drupal.org/project/danland",
  "minimum-stability": "dev",
  "support": {
    "issues": "https://www.drupal.org/project/issues/danland",
    "source": "https://git.drupalcode.org/project/danland"
  },
  "require": { }
}

As said, it is not stricly needed but convenient.
Greetings and thanks for the great work.

@EricVL Can you please create a separate issue and add the composer.json there, please? Adding a composer.json has nothing to do with D10 support.

@jcnventura

Sorry if I wronly have put it here but I thought it was a requirement of D10.
I've tried to install the theme without the composer.json file and it gave me an error. I don't know anymore what the error was but by adding the file, it was OK.
A new issue is made now.
Sorry again

I applied MR !2, which is working as expected, now i'm able to install theme in drupal 10.

RTBC ++

As suggested by @jcnventura

The D10 issue should then make sure to add the D10 support to this file.

Adding composer.json file.

I have reviewed and applied MR !2 this works for drupal 9.5 and drupal 10.0. and 10.0.1
Screenshots of the compatibility on 9.5 have been attached for reference:

Can be move to RTBC+1

I've committed #27 but there's still this code that is not doing what it was doing before:

diff --git a/danland.theme b/danland.theme
index 03464cc..6211118 100644
--- a/danland.theme
+++ b/danland.theme
@@ -63,8 +63,8 @@ function danland_preprocess_page(&$variables) {
   $variables['danland_bottom_b']['class'][] = 'in' . $bottom_b;
 
   $mask = '/\.(?:jp[e]?g|gif|png)$/i';
-  $files = \Drupal::service('file_system')->scanDirectory(drupal_get_path('theme', 'danland') . '/images/slideshows', $mask);
-  ksort($files);
+  $files = \Drupal::service('extension.list.theme')->getPath('danland') . '/images/slideshows' . $mask;
+  // ksort($files);
   $variables['files'] = $files;
   $variables['slideshow_display'] = theme_get_setting('slideshow_display', 'danland');
   $variables['slide1_url'] = theme_get_setting('slide1_url', 'danland');

Let's fix this so that a new release can be created.

jcnventura → closed merge request !2

Actually, the code for this provided by Project Bot in #2 should work just fine. Can someone please test it?

@jcnventura
I'm using this modification you sugested in #40 for months and it works.
The Project Bot in #2 is right.

@EricVL, if you have tested, I invite you to mark it as "Reviewed & tested by the community". It will just stay here until someone does that.

And yes, I'm trusting whoever does that change that the theme actually works for them like that, so please make sure it does.

Once this code gets committed, I'll do a release, so if there's anything anyone wants in that release in all the issues that are marked "Needs Review", please go and test those and mark them RTBC as well, please :)

@jcnventura
To be very clear and having no misunderstandings: the patch in #40 should still be applied to the code before this issue should have the state "Fixed".
Thank you

Hello,

I think, we should release a new version of this theme with only the modifications needed to make this theme Drupal 10 compatible because most of the modifications that are done in css on the dev branch are not fully tested and some do not even work properly.
Therefor it is probably better to make a new branch away from the 8.1_dev branch to make this possible if we do not want to wait for all the tests of the css modifications.
Just IMHO
Greetings

I'm sorry, I'm bit confused. Where do I get version working with Drupal 10.X? Or at least single patch to do this?

Automatically closed - issue fixed for 2 weeks with no activity.

Akshay kashyap → changed the visibility of the branch 3296924-automated-drupal-10 to active.