Automated Drupal 10 compatibility fixes

Once the ckeditor4 is deprecated now, maybe the dependencies in info.yml should be updated to ckeditor5?

Mysdiir → made their first commit to this issue’s fork.

- Updated Drupalbreaks to CKEditor5 object orientated architecture
- added DrupalbreaksFilterPlugin.php which uses FilterBase
- FakeObject become obsolete

I applied the MR !1 got error:

error: No valid patches in input (allow with "--allow-empty")

Could you provide the steps which step you have taken untill the error message came up?

Hello, I am trying to use the module on Drupal 10, I found your branch with fixes, but I cannot require the module because of the dependency on fakeobjects.

Maybe I am missing something, but I do not understand the composer.json of this module.

  "require": {
    "drupal/fakeobjects": "~8.0"
  }

It requires version 8? The drupal/fakeobjects is compatible Drupal10 but on version 1.2. So I am not really sure why it has 8.0. Am I missing something? Because 8.0 is not matching a branch name either. I changed the composer.json on a fork for 1.2 and the issue doesn't happen anymore. Could this be fixed on the Drupal 10 branch?

Heya phjou,
I will check this asap and give you feedback.
For the CKEditor 5 migration fakeobjects should't be necessary anymore and maybe I've just overseen it to exclude it.
I will give it a try asap :)

@Mysdiir

in #10 you say "deleted fakeobject as dependency from composer.json" --- in which branch/tag did you do that?

@drupatz You can find the code from @Mysdiir here https://git.drupalcode.org/issue/ckeditor_drupalbreaks-3296752/-/compare... - This should probably be better done with a merge request.

The suggestions made by @vanilla-bear don't seem much reasonable to me.

Sry forgot to open a MR the first time.
MR2 in 3296752-migration-to-ckeditor5

I've merged the automated patch, plus some minor changes: switching the \Drupal::service('extension.list.module')->getPath(...) to $this->getModulePath(), and changing the fakeobjects version constraint to ^1.2 per #9.

There's some good stuff in the MR from @Mysdiir which updates the plugin to work with CKEditor 5. However, (1) we should probably do the CKEditor 5 update in a different branch (2.0.x can stay compatible with Drupal 8, 9 and 10, with CKEditor 4 -- for which we need just the simple changes merged here), and (2) there's a bunch of miscellaneous other changes in there (.idea/, node_modules/, etc) and so it can't be merged as is.

@Mysdiir: I'd recommend opening a new issue and reducing your MR to just the changes necessary to update to CKEditor 5

Heya @dsnopek thx for your reply :)
I will open up a new branch this week due to tight time schedule on DrupalCon.

Automatically closed - issue fixed for 2 weeks with no activity.