- 🇩🇪Germany Anybody Porta Westfalica
@Grevil could you please have a look at this again?
Please note that the patch from #8 has code style issues and the module doesn't have test real coverage, so we have to be sure to not break anything. - Status changed to Closed: duplicate
over 1 year ago 1:17pm 29 June 2023 - 🇩🇪Germany Grevil
Most of the code inside "getActionTarget()" can be refactored, as the parent implementation is NOT private anymore. Comment in code:
// TODO: Write a Drupal.org issue to make this part a
// protected function in PageRedirect.
// We had to duplicate this code because we can't get our target
// from performAction().Let's solve this problem in 📌 Remove getActionTarget() as it isn't a private function anymore and can be inherited Closed: duplicate instead!
- Status changed to Active
over 1 year ago 1:31pm 29 June 2023 - 🇩🇪Germany Grevil
Ok, nvm upstream the target is also NULL, so we can not use the parent function... even if it is like 90% duplicated code.
- Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Not currently mergeable. - @grevil opened merge request.
- 🇩🇪Germany Grevil
Now with the changes from the MR, we get the same error as in 📌 Remove getActionTarget() as it isn't a private function anymore and can be inherited Closed: duplicate . So I guess this is a duplicate after all.
- Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Not currently mergeable. - last update
over 1 year ago 2 fail - last update
over 1 year ago 2 fail - last update
over 1 year ago 2 fail - Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Not currently mergeable. - last update
over 1 year ago 2 fail - last update
over 1 year ago 2 fail - Assigned to Anybody
- 🇩🇪Germany Grevil
I don't know, how to proceed here, the error message changed, but it is still broken. The problem is, that removing the "canonical" url, will lead to errors in drupal core (eventually D10 only). I'll create tests and assign this to @Anybody.
- 🇩🇪Germany Grevil
@Matroskeen gave a great core example in 📌 [2.0.x] Add support for Taxonomy Terms Closed: works as designed , to use instead of unsetting "canonical".
- 🇩🇪Germany Grevil
Setting this to major as the module isn't currently working at all for Drupal 10!
- Assigned to Grevil
- Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Not currently mergeable. - Issue was unassigned.
- 🇩🇪Germany Grevil
Alright no chance. The problem is, that we need to somehow change the canonical link of the entity type to dynamically use the redirect link from its current bundle. As the links are sitting on entity type level, this is a very niche endeavor to take on. Assigning this to @Anybody and creating tests.
The current refactor is a good start, but we still need to adjust rabbit_hole_href_entity_type_alter().
- last update
over 1 year ago 2 fail - last update
over 1 year ago 2 fail - Assigned to Anybody
- 🇩🇪Germany Grevil
Ok, just created the test! I will now assign this to @Anybody, to see if he can fix the issue!
Setting this to CRITICAL, as the current dev version is broken for Drupal >= 9.5.1.
Note, that as a final Attempt tried to revert everything to the state before 📌 Remove getActionTarget() as it isn't a private function anymore and can be inherited Closed: duplicate , to see if the old "getActionTarget()" implementation would make a difference. But unfortunately not. At some point, it became illegal to remove the "canonical" link.
- 🇩🇪Germany Grevil
Note that the current 2.0.1 release is also affected! Bummer that tests can not get executed in issues right now....