Contrib.social

Drupal Coding Standard Issue.

Open on Drupal.org ā†’
Created on 14 July 2022, over 2 years ago
Updated 3 June 2024, 7 months ago

$ phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml permission_watchdog/

FILE: C:\Users\SI-001\Downloads\permission_watchdog\permission_watchdog.install
-------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
-------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
-------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------

FILE: C:\Users\SI-001\Downloads\permission_watchdog\permission_watchdog.module
--------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
47 | WARNING | [ ] Line exceeds 80 characters; contains 126 characters
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: C:\Users\SI-001\Downloads\permission_watchdog\src\Entity\RoleChangeLog.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: C:\Users\SI-001\Downloads\permission_watchdog\src\Form\SettingsForm.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
43 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: C:\Users\SI-001\Downloads\permission_watchdog\src\Plugin\DevelGenerate\RoleChangeDevelGenerate.php
--------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
--------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------

FILE: C:\Users\SI-001\Downloads\permission_watchdog\src\Plugin\Field\FieldFormatter\PermissionActionDefaultFormatter.php
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------

FILE: C:\Users\SI-001\Downloads\permission_watchdog\src\Plugin\Field\FieldType\PermissionActionItem.php
-------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
-------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------

FILE: C:\Users\SI-001\Downloads\permission_watchdog\tests\src\Functional\PermissionWatchdogTest.php
---------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------

Time: 308ms; Memory: 10MB

šŸ“Œ Task
Status

Needs review

Version

2.0

Component

Code

Created by

šŸ‡®šŸ‡³India Rakhi Soni

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Open in Jenkins ā†’ Open on Drupal.org ā†’
    Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7
    last update 7 months ago
    6 pass
  • Comment 7 months ago ā†’
    šŸ‡®šŸ‡³India dev16.addweb

    Resolved all PHPCS issues including issue mentioned in #7. Please review.

  • First commit to issue fork.
  • Merge request !13295882: Fix phpcs issues ā†’ (Open) created by paraderojether
  • Open in Jenkins ā†’ Open on Drupal.org ā†’
    Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7
    last update 7 months ago
    6 pass
  • Comment 7 months ago ā†’
    šŸ‡µšŸ‡­Philippines paraderojether

    I reviewed patch #10 and confirmed it fixes the issues reported by phpcs. 

    permission_watchdog git:(2.x) curl https://git.drupalcode.org/project/permission_watchdog/-/merge_requests/1.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  6652    0  6652    0     0  22518      0 --:--:-- --:--:-- --:--:-- 22937
patching file permission_watchdog.install
patching file permission_watchdog.module
patching file 'src/Entity/RoleChangeLog.php'
patching file 'src/Form/SettingsForm.php'
patching file 'src/Plugin/DevelGenerate/RoleChangeDevelGenerate.php'
patching file 'src/Plugin/Field/FieldFormatter/PermissionActionDefaultFormatter.php'
patching file 'src/Plugin/Field/FieldType/PermissionActionItem.php'
patching file 'tests/src/Functional/PermissionWatchdogTest.php'
āžœ  permission_watchdog git:(2.x) āœ— cd ..
āžœ  contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig permission_watchdog
āžœ  contrib

    I also created an MR so that it would be easy for the maintainers to review.
    Please review the MR!. Thank you.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024