- 🇮🇳India prashant.c Dharamshala
Prashant.c → made their first commit to this issue’s fork.
- @prashantc opened merge request.
- 🇮🇳India prashant.c Dharamshala
Made a few changes to make the module compatible with Drupal 10.
It would be greatly appreciated if the module maintainers could create a release for Drupal 10 of this module after the review. It is widely used on many websites and will be advantageous during the upgrade process from Drupal 8 or 9 to 10.
Thank you.
- 🇬🇧United Kingdom steven jones
@Prashant.c thanks for the changes, are you able to explain why you needed to make some of them please?
- First commit to issue fork.
- @ccjjmartin opened merge request.
- 🇮🇳India prashant.c Dharamshala
@Steven
We of course needcore_version_requirement
to make it compatible with Drupal 10 and others were suggested by tools likedrupal-check
.Thanks
-
Steven Jones →
committed fa09a239 on 2.x
Issue #3295037: Add the default theme to tests.
-
Steven Jones →
committed fa09a239 on 2.x
-
Steven Jones →
committed 8f0ea9bf on 2.x
Issue #3295037: Make some assertions about the buttons.
-
Steven Jones →
committed 8f0ea9bf on 2.x
-
Steven Jones →
committed 2524fa70 on 2.x
Issue #3295037: Remove string translation.
-
Steven Jones →
committed 2524fa70 on 2.x
-
Steven Jones →
committed 3f61b3c6 on 2.x
Issue #3295037: Get the custom add another widget working in Drupal 10.
-
Steven Jones →
committed 3f61b3c6 on 2.x
-
Steven Jones →
committed c02d5f0f on 2.x
Issue #3295037: Get the custom add another widget working in Drupal 10.
-
Steven Jones →
committed c02d5f0f on 2.x
-
Steven Jones →
committed 6bffb98f on 2.x
Issue #3295037: Attempt to target the right button.
-
Steven Jones →
committed 6bffb98f on 2.x
-
Steven Jones →
committed 28eb0388 on 2.x
Issue #3295037: Attempt to target the right button.
-
Steven Jones →
committed 28eb0388 on 2.x
- 🇬🇧United Kingdom steven jones
I've started on 2.x branch for this work.
Automated tests are still failing though, which is a bit annoying!
-
Steven Jones →
committed f4c2c91d on 2.x
Issue #3295037: Try with a machine name.
-
Steven Jones →
committed f4c2c91d on 2.x
- Status changed to Fixed
over 1 year ago 4:05pm 27 April 2023 - 🇺🇸United States ccjjmartin Austin, TX
Just to post an update, I updated to 2.x and it fixed the deprecations and the module still works. Thanks for the quick response.
Automatically closed - issue fixed for 2 weeks with no activity.