- πΊπΈUnited States sassafrass
I would like to use this feature and was wondering what the latest status was?
- π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
There is no new status other than what you see in the comments.
- π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
Tagging 'Needs issue summary update'. We should add the remaining tasks there.
- @osopolar opened merge request.
- last update
over 1 year ago 49 pass - Open on Drupal.org βCore: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Not currently mergeable. - π©πͺGermany osopolar π©πͺ GER π
To clarify: I just needed to fix my old implementation, but the sub-module approach is the way to go.
- π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
Keeping my eye on this. Let me know when it's ready for review.
- Status changed to Needs review
over 1 year ago 12:18am 2 August 2023 - π©πͺGermany osopolar π©πͺ GER π
Merge request !35 is ready for review π.
- Status changed to Needs work
over 1 year ago 12:26am 2 August 2023 - π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
Had a quick look.
- We need to add aws sdk as a suggest to the
composer.json
- We need to add a requirements check for the sdk in the sub-module
.install
file
Have a look at how
search_api_opensearch_location
does it. - We need to add aws sdk as a suggest to the
- last update
over 1 year ago 49 pass - π©πͺGermany osopolar π©πͺ GER π
@kim.pepper: I added aws/aws-sdk-php to composer suggests. The requirements check for the sdk in the sub-module .install file is there:
if (!class_exists(Credentials::class)) { ...
- last update
over 1 year ago 49 pass - last update
over 1 year ago 47 pass, 4 fail - last update
over 1 year ago 49 pass - last update
over 1 year ago 49 pass -
kim.pepper β
committed ec4188cc on 2.x authored by
osopolar β
git commit -m 'Issue #3294653 by osopolar, kim.pepper: Provide an...
-
kim.pepper β
committed ec4188cc on 2.x authored by
osopolar β
-
kim.pepper β
committed ec4188cc on 3.x authored by
osopolar β
git commit -m 'Issue #3294653 by osopolar, kim.pepper: Provide an...
-
kim.pepper β
committed ec4188cc on 3.x authored by
osopolar β
- Status changed to Fixed
over 1 year ago 12:28am 11 August 2023 - π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
Merged to 2.x and 3.x. Thanks!
- π©πͺGermany osopolar π©πͺ GER π
Today I wanted to implement the feedback and found that everything was already done. Thank you kim.pepper for the finishing.
Automatically closed - issue fixed for 2 weeks with no activity.