Fulltext search is capped at 128 character limit

Hi, the patch works fine. Thank you.

Thanks for opening this issue, sounds like a good idea! Sorry for taking so long to respond, I had a pretty large backlog …

In any case, you’re right, while 128 characters is probably enough in most situations, no reason to limit to that by default.
However, I do wonder whether we shouldn’t just raise the limit instead of completely removing it, or make this configurable, to guard against attackers submitting massive fulltext queries to overload the search server. What’s your opinion on that?

As mentioned in the patch comment, the reason behind 128 is that in the core that is the default max length for textfields. However, I did find this issue 📌 Increase or remove default textfield #maxlength=128 Needs review where they are already planning to either remove the maxlimit or increase it to 256.

When it comes to this module, I personally also don't think it's smart to just remove the limit at least not by default, as @drunken monkey already also pointed out, it does work as a guard against attackers. I would either just increase the limit to something like 256 or at max 512, or make it configurable (where the default value is still 128).

Added a simple config, to set the max length and it defaults to 128. An empty value means no limit.

Thanks, looks great!
However, since this option should only affect the exposed form, it’s probably better to move it to that part of the filter options form. I also rephrased the label and description a bit, hope this is clearer.
Everyone, please test/review! This otherwise looks ready to be committed to me.

I like the patch, +1 :-)

It looks good to me. This way people can disable/increase the limit if they want to. Didn't break any other functionality in my testing so it can probably be merged.

Good to hear, thanks for testing/reviewing!
Committed. Thanks again, everyone!

Automatically closed - issue fixed for 2 weeks with no activity.