Drupal 10 compatibility for 8.x-5.x branch of Linkit

New maintainers would be wonderful, but I'm afraid I can be of no help at all with this: I simply don't have the skills/knowledge.

I agree that this is an exceptional module … in fact, I've often wished they would move it to core (although I also appreciate there may be good reasons why that shouldn't happen). I reckon there are probably a lot of sites that are waiting for this module to be made compatible with Drupal 10 so they can upgrade

Patch applied successfully to 9.5.x and 6.0.0 -beta3 and upgrade status now says "no problems found."

New maintainers would be wonderful, but I'm afraid I can be of no help at all with this: I simply don't have the skills/knowledge.

With ✨ Drastically improve the linking experience in CKEditor 5 Needs work on the way in Drupal core, I think maintainership could be limited to getting this D10 and CKEditor-5 compatible so as not to prevent sites from updating to D10 while the core solution for linking is in progress. I sent a message to johnwebdev, with whom I've worked in the past on other contrib modules, but have not yet heard back. I have therefore opened a maintainership request in https://www.drupal.org/project/linkit/issues/3338953 → , as the next step in transfer outlined by https://www.drupal.org/project/projectownership/ →

Feedback request

I think it might make sense, concurrent with the D10-compatible release of this module, to mark its lifecycle as "deprecated" per https://www.drupal.org/node/3215042 → and point to the core issue. That will help people starting new D10 sites to consider waiting to add LinkIt in favor of the upcoming core solution, and will help existing sites transfer to it. Thoughts?

Update on the status of a new release for Linkit: https://www.drupal.org/project/linkit/issues/3338953#comment-14908817 →

Hi Mark, I'm not sure if Linkit should be marked as deprecated, although I admit I may not fully understand what that implies. If I correctly (even though quickly) read the discussion about the improvements in Drupal core, they're not thinking about a full-featured replacement and there are several really important use cases where the proposed solution seems to be to "use the contrib Linkit module". So it seems they might be thinking that the two will sit alongside each other, perhaps?

Hi Andrew,

That's a completely valid point: the only circumstance under which we could mark LinkIt as "deprecated" (meaning, it has a replacement with feature parity and/or superiority) is if the Drupal core solution did, in fact, provide feature parity.

I agree that use case that you call out in ✨ Drastically improve the linking experience in CKEditor 5 Needs work -- the ability to specify whether certain media entity bundles should link directly to the media item or to the entity's "page" -- is critical. If it doesn't end up in core, LinkIt should live on.

Wonder if we can get a release for D10? Know the ckeditor5 stuff is still ongoing but consensus I've heard is people will upgrade to D10 before ckeditor5 since so many plugins are still in progress.

Pending the resolution of #3338953: Offering to co-maintain LinkIt → , I plan to make a D10-compatible release, yes, and that's not dependent on having CKEditor 5 support, since folks can use this module with the (now contrib) CKEditor 4 module.

Tried testing this out but now seems linkits are breaking

I see this error in the console

Uncaught ReferenceError: item is not defined

Tried testing this out but now seems linkits are breaking

I think there may be some outdatedness in this issue! Here's my understanding of where this ended up:

1. Drupal 10 compatibility (with CKEditor 4) was completed and merged into the 6.0.x branch in 🐛 Drupal 10 compatibility Fixed .
2. I tested that the branch itself, with the CKEditor 4 contrib module, works as expected using Drupal 10.1.x as of 2/22/2023.
3. All tests were passing when that was merged: https://www.drupal.org/pift-ci-job/2518144 →
4. The remaining, not-yet-merged work for CKEditor 5 support, which is *not* required for a D10-compatible release, comes from the 6.0.x branch.

We could conclude, then:

1. This issue, which referencess the 8.x-5.x branch, is effectively a duplicate of 🐛 Drupal 10 compatibility Fixed and can be closed. Drupal 10 compatibility is in the 6.0.x branch
2. We can create a separate issue for "Drupal 10 release" that can simply summarize the current state and reiterate that, upon resolution of #3338953: Offering to co-maintain LinkIt → , a new release will be issued: 6.0.0-alpha1.

Does that sound right to everyone?

Is there a way to get a 6.x d10 release then? Even if ckeditor5 is still in progress? Using a dev branch is something we try to avoid on a number of projects

Yep! As stated above, pending resolution of #3338953: Offering to co-maintain LinkIt → a new release will be issued: 6.0.0-beta4.

Posting a static patch because merge requests don't allow pinning to a specific commit, so anyone can submit pretty much anything and inject it into our codebase IIRC

Just a housekeeping update on this issue for D10 compatibility for the 8.x-5.x branch: A D10-compatible release of the 6.0.x branch, 6.0.0-beta4 → , was released on 5 March 2023.

What I could use help with, as a maintainer, is information about whether there is a reason that there still needs to be a D10-compatible release for the 8.x-5.x branch. For example, are there any open issues with patches specific to the 8.x-5.x branch people are depending on which don't have 6.0.x equivalents?

If we can provide feature parity in the 6.0.x branch and not make the update from 8.x-5.x onerous, that would be preferable than providing D10 (and CKEditor 5) compatibility for two branches.

Thanks in advance for community input!

Hi Mark,
I don't think so, that full D10 compatibility is needed in 5.x branch.

I'd go even further and question, if there's any good reason to further maintain the 5.x branch (besides some kind of emergency updates)? Because the 6.x branch is not D10 only, but also for 9.4 und 9.5 -> any older Drupal core version is no longer maintained, so you could be strict here too. I'd prefer, if you don't waste any of your valuable time on maintaining old branches

I have clarified the current status for D10 support in the issue title and description.

Based on the comments in #22 and #23, I'm going to mark this issue as closed (outdated). Sites using this code can certainly continue to do so,

For participation and information in Linkit's roadmap, see 🌱 LinkIt Release Roadmap and Issue Prioritization Active .

Thanks, community, for you collaboration and consideration!