- 🇫🇷France Chris64 France
Same patch than #3093730 🐛 Hidden columns not expandable [1.x] Needs review . Could be applied successfully for the 2.0.0 version. Not for the 2.x-dev one since the file datatables.js has changed. Here this patch for that version.
- Status changed to Needs work
over 1 year ago 5:35am 17 April 2023 - Status changed to Needs review
about 1 year ago 12:45pm 27 September 2023 - 🇫🇷France Chris64 France
Nothing new here? @Anybody, not convinced? May be, to move forward,
- does the suggested code solves the problem? If not what are its functional problems?
- does the suggested code is better than the current one?
- if this code is not good, which code rather? - 🇫🇷France Chris64 France
More arguments. Found in Drupal core 10.1 or 9.5,
theme.prototype: 0 occurrences
Drupal.theme.: >50 occurrences
In contrib/,
theme.prototype: 1 occurrence:datatables/js/datatables.js
:139
Drupal.theme.: >20 occurrences - 🇩🇪Germany Anybody Porta Westfalica
If someone else can confirm and explain this change is correct, we can set this RTBC this of course.
- Drupal.theme.prototype.datatablesExpandableRow = function (datatable, row) { + Drupal.theme.datatablesExpandableRow = function (datatable, row) {
- Status changed to Needs work
about 1 year ago 8:35pm 10 November 2023 - 🇩🇪Germany Anybody Porta Westfalica
@Chris64 could you please prepare #4 as MR for further review?
- Status changed to Needs review
about 1 year ago 6:06pm 18 November 2023 - Status changed to RTBC
about 1 year ago 8:53am 20 November 2023 - 🇩🇪Germany Anybody Porta Westfalica
General RTBC for MR!13 still this is a case, where tests would help a lot to ensure we don't break any (edge)cases. The maintainer should decide. At least I'd merge this last and keep it in dev for a while, before tagging a release.
- 🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin
Again, I think we are not on the road breaking things badly at the moment and in times when things move forward slowly I recommend to go forward before cutting nervs of contributors with tests. I would stand on tests more if this project would have more critical impact in the center of a Drupal installation but in this case here and especially because at the moment it is a hand full of contributors pushing things forward here only, I will take the heard and courage to push things and wait until some things pop up ;-)
Again thanks @ all for all the hard work.
- Status changed to Fixed
11 months ago 7:17pm 17 January 2024 - 🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin
Merged to latest dev and prepared for queue into 2.0.1 (Drupal 10 compatible) release this month.
Automatically closed - issue fixed for 2 weeks with no activity.