- πΊπΈUnited States greggles Denver, Colorado, USA
Looks good to me as well.
- πΊπΈUnited States rymcveigh
The code changes look good to me. I wonder if there is a good way to reproduce the issue though. Are there any tests in the code base that triggers this error?
- Status changed to Needs work
almost 2 years ago 6:53pm 22 February 2023 - πΊπΈUnited States rymcveigh
The patch seems to be missing a couple
$stats_data
uses. I see it being used on lines 233, 234, 239, 295, and 347. Your patch seems to be missing the if empty check on line 234. It seems like we will want to make sure the function returns an empty array if$statsdata
is empty. - @rymcveigh opened merge request.
- Status changed to Needs review
almost 2 years ago 7:02pm 22 February 2023 - πΊπΈUnited States rymcveigh
I created an MR that is built on the 8.x-2.x branch. It looks like some of the changes in your patch had been addressed in a prior merge so the number of changes needed has decreased since the creation of that patch.
- Status changed to RTBC
almost 2 years ago 8:21pm 22 February 2023 - πΊπΈUnited States greggles Denver, Colorado, USA
Thanks for that update, Ryan. Still looks RTBC to me.
- First commit to issue fork.
-
Perignon β
committed 9770f228 on 8.x-2.x authored by
rymcveigh β
Issue #3291891: Stats data variable name mismatch
-
Perignon β
committed 9770f228 on 8.x-2.x authored by
rymcveigh β
- Status changed to Fixed
almost 2 years ago 1:13am 24 February 2023 - πΊπΈUnited States Perignon
Merged PR! Thanks for the contribution!
Automatically closed - issue fixed for 2 weeks with no activity.