- 🇩🇰Denmark ressa Copenhagen
Great module, thanks for making and maintaining it!
The patch from #3 applies, and the module works well in Drupal 10, where terms can be used as arguments. I did get this error after adding a path to a view and saving it:
Symfony\Component\Routing\Exception\RouteNotFoundException: Route "view.test.page_1" does not exist. in Drupal\Core\Routing\RouteProvider->getRouteByName() (line 206 of /app/web/core/lib/Drupal/Core/Routing/RouteProvider.php).
But refreshing the page made the error go away, and the view could be filtered, using terms.
The last submitted patch, 3: views_taxonomy_term_name_into_id.1.x-dev.rector.patch, failed testing. View results →
- Assigned to dww
- Status changed to Needs work
about 2 years ago 1:16am 14 March 2023 - 🇺🇸United States dww
This no longer applies after 🐛 ArgumentValidatorTest::setUp() is not compatible with ViewTestBase::setUp() since Drupal 9.4.x Fixed , which we needed to fix before we could get any valid test results at all in here.
- Status changed to Needs review
about 2 years ago 1:40am 14 March 2023 - 🇺🇸United States dww
Ugh yeah, and various kinds of broken with the automated patch:
- Using
protected $modules
breaks testing in8.9.x
, so either we have to be fancy (which I'm doing) or we actually wouldn't still support^8 || ^9 || ^10
as the patch suggests. views_taxonomy_term_name_into_id_test.info.yml
also needs to be updated to say it's compatible with D10.
Both fixed here. In local testing on 8.9.x, 9.5.x and 10.1.x branches, all tests are now passing again.
Let's see what DrupalCI has to say now...
- Using
- Status changed to RTBC
about 2 years ago 1:46am 14 March 2023 - 🇺🇸United States dww
Oh right, the bot can't test this until I commit it. 😂 Hurray for local testing. I think this is ready.
- Issue was unassigned.
- Status changed to Fixed
about 2 years ago 1:48am 14 March 2023 Automatically closed - issue fixed for 2 weeks with no activity.