Automated Drupal 10 compatibility fixes

Created on 16 June 2022, over 2 years ago
Updated 6 March 2024, 10 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects โ†’

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot โ†’ official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot โ†’ or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot โ†’ , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue โ†’ . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue โ†’ .

๐Ÿ“Œ Task
Status

RTBC

Version

1.0

Component

Code

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • ๐Ÿ‡ง๐Ÿ‡ทBrazil halth Brazil

    Confirming that the patch provided by the @project-update-bot fixes the issue.

    I've created a new MR.

  • Status changed to RTBC over 1 year ago
  • ๐Ÿ‡ง๐Ÿ‡ทBrazil halth Brazil

    Anyone that could help me get this reviewed and eventually approved/merged?

  • thanks for the MR, halth. looks good to me, but I'm a first-time contributor and not sure how to 'officially' submit a review - does this count or do I need to do something in gitlab?

  • ๐Ÿ‡ง๐Ÿ‡ทBrazil halth Brazil

    Hi Alyssa! Thanks for reaching out.

    You can contribute to this just by confirming you've tested the patch/MR above and flagging that it works for you.
    That reinforces the Reviewed & tested by the community status, increasing the level of confidence on maintainers to accept it.

    However, only an official project maintainer can merge the MR into the project and release a new version.
    Unfortunately, they haven't paid attention to this issue yet.

    I've tried reaching out to them on Drupal Slack directly, without success.

    I think the best we can do for now is wait.

    In case you can't wait on them, here are a few options you have to get around the D10 incompatibility issue:

    - Make use of Composer Drupal Lenient to "whitelist" this module, so the version compatibility constraint won't prevent you from upgrading to Drupal 10:

    "drupal-lenient": {
                "allowed-list": ["drupal/path_file"]
            }

    - Apply the MR above as a patch using cweagans/composer-patches:

    "patches": {
                "drupal/path_file": {
                    "Issue #3289025: Automated Drupal 10 compatibility fixes": "https://www.drupal.org/files/issues/2022-06-16/path_file.1.x-dev.rector.patch"
                }
    }

    If this project gets abandoned moving into the future but you still need the functionality, you could also turn it into a "custom contrib" module, which pretty much consists of removing the Composer Dependency for this module, moving it to modules/custom and treating it as a custom project.

    I hope this sheds some light on your way.

  • Thanks so much, Heitor! My site authors rely on this module so I really appreciate the extra upgrade recommendations - didn't know about Composer Drupal Lenient, which sounds like it might solve this and a couple of my other module upgrade problems :)

  • Confirming that I have tested the patch provided by the @project-update-bot and it fixes the issue.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States kbeck303

    Also confirming the patch in #2 ๐Ÿ“Œ Automated Drupal 10 compatibility fixes RTBC works with Drupal 9.5.10. The Merge request in #5 ๐Ÿ“Œ Automated Drupal 10 compatibility fixes RTBC does not work because of a syntax issue with the ^ symbol.

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia ashetkar

    After adding patch #2 getting issue as " Adding non-existent permissions to a role is not allowed. The incorrect permissions are "View published Path file entity entities".

  • First commit to issue fork.
  • @kmani opened merge request.
  • @kmani opened merge request.
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States jpro

    Is there any hope this module will ever have an official release for version 10? Has it been abandoned?

  • ๐Ÿ‡ณ๐Ÿ‡ฑNetherlands bram.velthoven

    Is there any more information on if there will be an official d10 compatible release?

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Abby.Mns

    Rohit.Mns โ†’ made their first commit to this issueโ€™s fork.

Production build 0.71.5 2024