Automated Drupal 10 compatibility fixes

Created on 16 June 2022, over 2 years ago
Updated 28 February 2023, over 1 year ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue .

📌 Task
Status

Fixed

Version

1.0

Component

Code

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇯🇴Jordan Rajab Natshah Jordan

    Had Real physical testing round for Node Edit Protection 1.0.x-dev with Drupal ~10 and Drupal ~9.0

    Used the following steps in the attached file
    Real-physical-testing-round-for-Node-Edit-Protection-1-0-x-dev--with-d10-and-d9.zip

    Had Real physical testing round for Node Edit Protection 1.0.x-dev with Drupal ~10

    mkdir -p /var/www/html/sandboxes
    composer create-project drupal/recommended-project:~10.0 /var/www/html/sandboxes/drupal10node_edit_protection_1__test
    cd /var/www/html/sandboxes/drupal10node_edit_protection_1__test/
    composer require drush/drush:~11.0;
    

    Change minimum stability to dev for testing on the recommended Drupal 10 project template

    composer config minimum-stability dev
    

    Add the Node Edit Protection module

    mkdir -p /var/www/html/sandboxes/drupal10node_edit_protection_1__test/web/modules/contrib
    cd /var/www/html/sandboxes/drupal10node_edit_protection_1__test/web/modules/contrib/
    git clone --branch '8.x-1.x' https://git.drupalcode.org/project/node_edit_protection.git
    

    Git apply the needed patch

    cd /var/www/html/sandboxes/drupal10node_edit_protection_1__test/web/modules/contrib/node_edit_protection/
    wget https://www.drupal.org/files/issues/2022-06-16/node_edit_protection.1.x-dev.rector.patch
    git apply node_edit_protection.1.x-dev.rector.patch
    

    Change file/directory mod and ownership of files:

    cd /var/www/html/sandboxes/drupal10node_edit_protection_1__test/
    sudo chmod 775 -R .;sudo chown www-data:$USER -R .;
    

    Install with Drush

    ./vendor/drush/drush/drush site:install standard --yes --site-name="Node Edit Protection 1.0.x-dev - Real physical testing with Drupal ~10" --account-name="webmaster" --account-pass="d" --account-mail="test@drupal.org" --db-url="mysql://root:123___@localhost/sandboxes_drupal10node_edit_protection_1__test" -vvv ;
    
    ./vendor/drush/drush/drush pm:enable node_edit_protection
    

    Rebuild the cache:

    sudo chmod 775 -R .;sudo chown www-data:$USER -R .;
    ./vendor/drush/drush/drush cache:rebuild
    

    Open a browser and change the address to: http://localhost/sandboxes/drupal10node_edit_protection_1__test/web/
    After a login with the user no. 1
    ---
    While creating a new content or editing, the JavaScript message will show up if the editor clicked or a link which redirect to other pages.

  • 🇯🇴Jordan Rajab Natshah Jordan

    No extra change for JavaScript.
    The patch in #2 is ready to be committed.
    Ready for a tag release. Working well with Drupal 10 and Drupal 9.

  • First commit to issue fork.
  • 🇦🇺Australia realityloop

    I added the patch to an issue branch, as well as adding a composer.json file so that I could use it in composer without the need for the patch, allowing me to upgrade to Drupal 10.

    The following (or similar) is required in your projects composer.json:

        "repositories": {
            "drupal": {
                "type": "composer",
                "url": "https://packages.drupal.org/8",
                "exclude": [
                    "drupal/node_edit_protection"
                ]
            },
            "drupal/node_edit_protection": {
                "type": "git",
                "url": "https://git.drupalcode.org/issue/node_edit_protection-3288778.git"
            }
        },
    

    Then add the module using: composer require drupal/node_edit_protection:dev-3288778-automated-drupal-10

    I hope this is helpful to others.

  • 🇦🇺Australia acbramley

    @realityloop you can also use https://github.com/mglaman/composer-drupal-lenient to get around that issue without having to setup the custom repo.

  • 🇯🇴Jordan Rajab Natshah Jordan

    Thanks, Brian.
    Good to learn that we can do the way around from #13
    It will be used for sure, in other not Drupal 10 upgraded projects too.
    Thanks, Adam for the link to composer-drupal-lenient
    Worth testing with. It will help a lot with the automated update process.

  • Status changed to Fixed over 1 year ago
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024