Automated Drupal 10 compatibility fixes

Created on 15 June 2022, over 2 years ago
Updated 8 August 2024, 5 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue .

📌 Task
Status

Fixed

Version

2.0

Component

Code

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇺🇸United States DamienMcKenna NH, USA

    This worked great in some quick testing I did using the find/replace plugin. I didn't test all of the plugins, but it should be a good start.

  • 🇳🇱Netherlands Summit

    Hi,

    Feeds_Tamper.Dev didn't install in latest Drupal 10 through composer, PHP 8.1
    composer require 'drupal/feeds_tamper:2.x-dev@dev'
    Error

    Problem 1
        - drupal/feeds_tamper dev-2.x requires drupal/tamper ^1.0-alpha3 -> found drupal/tamper[dev-1.x, 1.0.0-alpha3, 1.x-dev (alias of dev-1.x)] but it does not match your minimum-stability.
        - drupal/feeds_tamper 2.x-dev is an alias of drupal/feeds_tamper dev-2.x and thus requires it to be installed too.
        - Root composer.json requires drupal/feeds_tamper 2.x-dev@dev -> satisfiable by drupal/feeds_tamper[2.x-dev (alias of dev-2.x)].
    

    Greetings, Martijn

  • 🇳🇱Netherlands Summit

    Hi,
    with latest version 10 still

    composer require 'drupal/feeds_tamper:*'
    Info from https://repo.packagist.org: #StandWithUkraine
    ./composer.json has been updated
    Running composer update drupal/feeds_tamper
    Loading composer repositories with package information
    Updating dependencies
    Your requirements could not be resolved to an installable set of packages.
      Problem 1
        - Root composer.json requires drupal/feeds_tamper *, found drupal/feeds_tamper[dev-2.x, 2.0.0-beta1, 2.0.0-beta2, 2.0.0-beta3, 2.x-dev (alias of dev-2.x)] but it does not match your minimum-stability.
    Installation failed, reverting ./composer.json and ./composer.lock to their original content.
    

    How can I resolve this, shouldn't first the patch be committed?
    Thanks for your reply in advance, Greetings,

  • 🇳🇱Netherlands Summit

    Hi,
    I resolved this through stability
    I had to set the stability to 'dev' and then the module installed through composer.
    Greetings,

  • 🇳🇱Netherlands megachriz

    @summit
    Yes, because Feeds Tamper has no stable release yet, the stability setting in composer.json can prevent the module from getting installed through composer.

  • 🇺🇸United States savanahsteigen@gmail.com

    I'm getting the following error when trying to install feeds_tamper.

    I'm running Drupal 10.1.8 and Feeds 8.x-3.0-beta4.

    Please let me know if there is any additional information that would be helpful.

    composer require 'drupal/feeds_tamper:^2.0@beta'
    
    ./composer.json has been updated
    Running composer update drupal/feeds_tamper
    Loading composer repositories with package information
    Updating dependencies
    Your requirements could not be resolved to an installable set of packages.
    
      Problem 1
        - drupal/feeds_tamper 2.0.0-beta1 requires drupal/core ^8.5.0 -> found drupal/core[8.5.0, ..., 8.9.20] but the package is fixed to 10.1.8 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.
        - drupal/feeds_tamper 2.0.0-beta2 requires drupal/core ^8 || ^9 -> found drupal/core[8.0.0, ..., 8.9.20, 9.0.0, ..., 9.5.11] but the package is fixed to 10.1.8 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.
        - drupal/feeds_tamper 2.0.0-beta3 requires drupal/tamper ^1.0-alpha3 -> found drupal/tamper[dev-1.x, 1.0.0-alpha3, 1.0.0-alpha4, 1.x-dev (alias of dev-1.x)] but it does not match your minimum-stability.
        - Root composer.json requires drupal/feeds_tamper ^2.0@beta -> satisfiable by drupal/feeds_tamper[2.0.0-beta1, 2.0.0-beta2, 2.0.0-beta3].
    
    Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.
    
    Installation failed, reverting ./composer.json and ./composer.lock to their original content.
    
  • 🇳🇱Netherlands megachriz

    @_San_
    I think that the minimum stability setting in your composer.json could be the issue. Since Tamper is in alpha, that setting would need to be alpha in order to resolve that dependency of Feeds Tamper.

    So in composer.json, you would need to have this:

    "minimum-stability": "alpha",
    

    You could also require the Tamper module separately, I think that would work as well. Then you would have these commands:

    composer require drupal/tamper:^1.0@alpha
    composer require drupal/feeds_tamper:^2.0@beta
    

    That could be a better choice if you rather not would use modules that do not have a stable release yet. The reason that Tamper does not have a stable release yet, is because not all plugins available in the D7 version are ported yet.

  • Status changed to Fixed 5 months ago
  • 🇳🇱Netherlands megachriz

    Drupal 10 is out for some time now, and we now have an issue for D11 compatibility, so this issue can be closed.
    📌 Automated Drupal 11 compatibility fixes for feeds_tamper Active

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024