Contrib.social

Automated Drupal 10 compatibility fixes

Open on Drupal.org →
Created on 15 June 2022, about 2 years ago
Updated 20 November 2023, 7 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects →

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Needs work

Version

1.0

Component

Code

Created by

Project Update Bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment about 1 year ago →
    🇨🇳China fishfree

    Why not merge and release for D10?

  • Comment about 1 year ago →
    🇫🇮Finland back-2-95 Helsinki

    Release would be nice, we need to use mglaman/composer-drupal-lenient for even install the module with the patch.

  • First commit to issue fork.
  • @martinsbruvelis opened merge request.
  • Status changed to RTBC 9 months ago
  • Comment 9 months ago →
    🇮🇪Ireland markconroy

    Marking this as RTBC.

    Any chance we could get a new release of this module soon please?

  • Comment 9 months ago →
    🇮🇪Ireland markconroy

    Since this module is not receiving any updates, I don't see the point in having it in my codebase any more. However, if you uninstall it, it deletes your "Countries" taxonomy and also removes all the terms/countries in it.

    To get around this, you can:

    1. Open countries_info.install file
    2. Delete the countries_info_uninstall() function
    3. Uninstall the module
    4. Deploy this change to your website
    5. Remove the module from your codebase
    6. Deploy this change to your website

    Sorry, I know this isn't helping get this issue merged, but it's a workaround for you to get your site to Drupal 10.

  • Comment 9 months ago →
    🇫🇮Finland back-2-95 Helsinki

    You can install this module to Drupal 10 site with this patch using mglaman/composer-drupal-lenient Composer plugin.

  • Status changed to Needs work 7 months ago
  • Comment 7 months ago →
    🇪🇸Spain saganakat

    I've tried applying the patch, but it's giving me an error in the execution of Composer:

    Hunk #1 FAILED at 5.
1 out of 1 hunk FAILED -- saving rejects to file countries_info.info.yml.rej

patch '-p0' --no-backup-if-mismatch -d '/var/www/html/docroot/modules/contrib/countries_info' < '/tmp/655b554f88e2f.patch'
Executing command (CWD): patch '-p0' --no-backup-if-mismatch -d '/var/www/html/docroot/modules/contrib/countries_info' < '/tmp/655b554f88e2f.patch'
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/countries_info.info.yml b/countries_info.info.yml
|index 72f2677..80d1ce6 100644
|--- a/countries_info.info.yml
|+++ b/countries_info.info.yml

    The issue is on line 6, which it identifies as a removal instead of text that shouldn't be modified:

    - drupal: taxonomy

    Upload a new patch to fix this.

  • Comment 7 months ago →
    🇮🇪Ireland markconroy

    @saganakat you can't patch a .info.yml file.

    The file might look like this when the patch is created:

    name: My Module
description: A module that does something
core_version_requirement: ^9 || ^10

    But after Drupal packages it, it looks like this:

    name: My Module
description: A module that does something
core_version_requirement: ^9 || ^10

# Information added by Drupal.org packaging script on 2023-09-29
version: '3.4.2'
project: 'my_module'
datestamp: 1696006156

    So git sees it as having changed and can't patch it any more.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024