Automated Drupal 10 compatibility fixes

@geek-merlin, CKE4 contrib module is still relevant, as migration to CKE5 is not that easy and will take a lot of time

@mark_fullmer, I think we need to move forward with support of CKE4 contrib here

Right, i see. So let's think about the future of this module.

1 I s/o applies as comaintainer of ckeditorheight, i'm open to assign a competent person.
2 If this goes into the ckeditor4 contrib module, i'm happy to deprecate this.
3 Of course we can do 1 until 2 happens.

I made a patch for the recommended version (8.x-1.8) based on the available patch for 8.x-1.x-dev ( https://www.drupal.org/files/issues/2023-04-24/3286522-d10-compatibility... → )

I added Drupal.org packaging script information to the `info.yml` file because without it was failing to apply.

Also, if someone(tm) rolls a MR, i can do the one click commit thing.

Maksym Fedorchuk → made their first commit to this issue’s fork.

Thanks! The testbot complains though:

Unable to install modules: module 'ckeditorheight' is missing its dependency module ckeditor.

I dimly remember that there are d.o issues with that type of dependencies...

@geek-merlin, I do believe it's because

• ckeditor is not part of the d10 core
• drupalci does not resolve dependencies without a composer.json file

see https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... →

Note on automated tests and dependencies: If your project has dependencies on other projects, but you have not created a composer.json file for your project, the dependencies will not be resolved and fetched from the merge request, and your tests will then be likely to fail. The resolution is to create a composer.json file for your project.

Thx for the quick research and fix!

Pushed and released.

Automatically closed - issue fixed for 2 weeks with no activity.