Contrib.social

Automated Drupal 10 compatibility fixes

Open on Drupal.org →
Created on 15 June 2022, over 2 years ago
Updated 5 January 2024, 12 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects →

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

RTBC

Version

3.1

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Issue was unassigned.
  • Status changed to Needs review almost 2 years ago
  • Comment over 1 year ago →
    🇵🇰Pakistan hmdnawaz

    Dont know why but the patch in # 6 is not applied.

  • Comment over 1 year ago →
    🇵🇰Pakistan hmdnawaz

    I'm getting the following error with the patches in # 6 and 7.

    TypeError: Drupal\broken_link\EventSubscriber\BrokenLinkSubscriber::handleBrokenLink(): Argument #1 ($event) must be of type Symfony\Contracts\EventDispatcher\Event, Symfony\Component\HttpKernel\Event\ExceptionEvent given in Drupal\broken_link\EventSubscriber\BrokenLinkSubscriber->handleBrokenLink() (line 44 of modules/contrib/broken_link/src/EventSubscriber/BrokenLinkSubscriber.php).

    What can be the reason?

  • Comment over 1 year ago →
    Wotanether

    Hi,
    I think it's because a subscriber with the "kernel.exception" event should use Symfony\Component\HttpKernel\Event\ExceptionEvent instead of Symfony\Contracts\EventDispatcher\Event and according to this page → using Symfony\Contracts\EventDispatcher\Event can lead to fatal errors.
    In addition, $exception = $event->getException(); should be replaced by $exception = $event->getThrowable(); in BrokenLinkSubscriber.php line 45 because the method getException () is deprecated since symfony 4 and trigger a fatal error in D10.
    I worked on a patch and it seems to work on my local D10 environment.

  • Status changed to RTBC over 1 year ago
  • Comment over 1 year ago →
    🇲🇽Mexico manoxs Guadalajara

    Hi,

    I found the same issue mentioned on: PHP8.1: Deprecated function: trim() 🐛 PHP8.1: Deprecated function: trim() RTBC merging the fix in here

  • First commit to issue fork.
  • Comment about 1 year ago →
    🇵🇰Pakistan hmdnawaz

    The patch in #10 does not apply to the latest version.

    Here is the new patch.

  • Comment about 1 year ago →
    🇵🇰Pakistan hmdnawaz
  • @tonibarbera opened merge request.
  • First commit to issue fork.
  • Comment about 1 year ago →
    🇩🇪Germany vistree

    Can MR from #15 be merged - or are there outstanding problems?

  • Comment about 1 year ago →
    🇨🇦Canada phjou Vancouver 🇨🇦 🇪🇺

    Can this be merged to add Drupal 10 support?

    Drupal 9 is not supported anymore and consequently making this module deprecated for the time being. We currently have to rely on a fork and it would be great to come back to a regular workflow depending on drupal.org.

  • Comment about 1 year ago →
    🇨🇦Canada phjou Vancouver 🇨🇦 🇪🇺
  • Comment about 1 year ago →
    🇨🇦Canada phjou Vancouver 🇨🇦 🇪🇺

    Bumping priority since Drupal 9 reached end of life.

  • Comment 12 months ago →
    🇩🇪Germany vistree

    Can someone explain why the D10 compatibility patch is not merged? Are there outstanding problems?

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024