Contrib.social

Automated Drupal 10 compatibility fixes

Open on Drupal.org →
Created on 15 June 2022, over 2 years ago
Updated 8 September 2023, about 1 year ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects →

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

Project Update Bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago →
    Project Update Bot

    This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

    It is important that any automated tests available are run with this patch and that you manually test this patch.

    Drupal 10 Compatibility

    According to the Upgrade Status module → this patch makes this module compatible with Drupal 10! 🎉
    Therefore this patch updates the info.yml file for Drupal 10 compatibility.

    Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

    Debug info

    Bot run #12554

    This patch was created using these packages:

    1. mglaman/phpstan-drupal: 1.1.35
    2. palantirnet/drupal-rector: 0.15.1
  • First commit to issue fork.
  • Comment over 1 year ago →
    🇮🇳India dineshkumarbollu

    Hi

    After applying the patch still D10 compatible issues are there.

    vendor/bin/drush upgrade_status:analyze acb
    [notice] Processing /var/www/html/contributions/web/modules/contrib/acb-3285906.

    ================================================================================
    Access Control Bridge, --
    Scanned on Tue, 07/11/2023 - 15:30

    FILE: web/modules/contrib/acb-3285906/acb.module

    STATUS LINE MESSAGE
    --------------------------------------------------------------------------------
    Fix now 39 Call to deprecated method getImplementations() of class
    Drupal\Core\Extension\ModuleHandlerInterface. Deprecated in
    drupal:9.4.0 and is removed from drupal:10.0.0. Instead you
    should use ModuleHandlerInterface::invokeAllWith() for hook
    invocations or you should use
    ModuleHandlerInterface::hasImplementations() to determine if
    hooks implementations exist.
    --------------------------------------------------------------------------------
    Fix now 40 Call to deprecated method getImplementations() of class
    Drupal\Core\Extension\ModuleHandlerInterface. Deprecated in
    drupal:9.4.0 and is removed from drupal:10.0.0. Instead you
    should use ModuleHandlerInterface::invokeAllWith() for hook
    invocations or you should use
    ModuleHandlerInterface::hasImplementations() to determine if
    hooks implementations exist.
    --------------------------------------------------

  • Assigned to dineshkumarbollu
  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago →
    🇮🇳India dineshkumarbollu

    i will work on it.

  • @dineshkumarbollu opened merge request.
  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇮🇳India dineshkumarbollu

    Hi

    I created MR for this issue and aslo attaching D10 report.

    Thanks

  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago →
    🇺🇦Ukraine i-trokhanenko Lutsk 🇺🇦

    I think it would be nice to keep Drupal 9 compatibility, can we add something like this to the "acb_get_modules" function?

      if (version_compare(\Drupal::VERSION, '9.4', '>=')) {
    $modules = array_unique(
      array_merge(
        \Drupal::moduleHandler()->hasImplementations('node_grants'),
        \Drupal::moduleHandler()->hasImplementations('node_access_records')
      )
    );
  }
  else {
    $modules = array_unique(
      array_merge(
        \Drupal::moduleHandler()->getImplementations('node_grants'),
        \Drupal::moduleHandler()->getImplementations('node_access_records')
      )
    );
  }
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇺🇦Ukraine i-trokhanenko Lutsk 🇺🇦

    Added D10 compatibility while keeping D9 functionality, please review

  • Comment about 1 year ago →
    System Message
  • Status changed to Fixed about 1 year ago
  • Comment about 1 year ago →
    🇺🇦Ukraine i-trokhanenko Lutsk 🇺🇦

    Committed the #11 patch

  • Comment about 1 year ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024