- šµšPhilippines cleavinjosh
Hi @uravshi_vora,
I applied patch #11, it was applied smoothly and fixed most of the phpcs issues.
These are the remaining issues after I ran
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml:ā bealestreet git:(8.x-1.x) curl https://www.drupal.org/files/issues/2022-12-20/coding-standards-3285835-11.patch | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 66531 100 66531 0 0 178k 0 --:--:-- --:--:-- --:--:-- 178k patching file README.txt patching file bealestreet.info.yml patching file bealestreet.libraries.yml patching file bealestreet.theme patching file config/install/bealestreet.settings.yml patching file css/blue.css patching file css/green.css patching file css/orange.css patching file css/red.css patching file css/style.css patching file css/suckerfish_blue.css patching file css/suckerfish_green.css patching file css/suckerfish_orange.css patching file css/suckerfish_red.css patching file js/pickstyle.js patching file js/suckerfish.js patching file templates/comment.html.twig patching file templates/node.html.twig patching file templates/page.html.twig patching file theme-settings.php ā bealestreet git:(8.x-1.x) ā .. ā contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml bealestreet FILE: /Users/interns/Demo-site/drupal-org-issues/web/themes/contrib/bealestreet/bealestreet.theme -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 20 | ERROR | The $_COOKIE super global must not be accessed directly; inject the request_stack service and use $stack->getCurrentRequest()->cookies->get("bealestyle") instead 21 | ERROR | The $_COOKIE super global must not be accessed directly; inject the request_stack service and use $stack->getCurrentRequest()->cookies->get("bealestyle") instead -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- Time: 308ms; Memory: 12MB ā contribThank you.
- Assigned to amit.rawat777