Remove the limit of the explode from Utility::splitCombinedId

Created on 14 June 2022, over 2 years ago
Updated 19 March 2024, 9 months ago

Problem/Motivation

It's possible to extends the item id with extra info by implementing a denormalisation processor (both in contrib as custom). The explode in method Utility::splitCombinedId with limit 2 breaks loading the correct items because a wrong id is returned.

Steps to reproduce

Use a module with the denormalisation processor implemented. Example of a contrib: search_api_grouping

Code abstract (very abstract):

Method: alterIndexedItems(array &$items): void;
Class: class Denormalize extends ProcessorPluginBase implements PluginFormInterface;
...
        $id = $item_id . IndexInterface::DATASOURCE_ID_SEPARATOR . $property . IndexInterface::PROPERTY_PATH_SEPARATOR . $delta;
        $items[$id] = $this->createDocument($item, $id, $property, $delta);
..

Result when breaking on the splitCombinedId method: entity:node/14027:en/field_dates:0

Proposed resolution

Remove the limit from the explode in method Utility::splitCombinedId.

Remaining tasks

Needs review

Feature request
Status

Closed: won't fix

Version

1.0

Component

General code

Created by

🇧🇪Belgium cgoffin

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024