- Assigned to aneek
- Issue was unassigned.
- Status changed to Needs review
12 months ago 4:19pm 1 April 2024 - last update
12 months ago Build Successful - 🇺🇸United States DamienMcKenna NH, USA
Rerolled. Removes the STRONG tag and fixes some coding standards.
- 🇺🇸United States DamienMcKenna NH, USA
The placement of the text beside the time field can be a little off. I wonder if it'd be better to just have a single comment at the top of the fieldset that said e.g. "All times are in [timezone]" rather than adding a suffix on each field?
- 🇺🇸United States DamienMcKenna NH, USA
Does the timezone problem boil down to some timezone translation that core is performing on the field? This site is configured to run in America/Chicago, I'm in America/New_York; when I load the form the browser defaults to e.g. 12:30pm, but when I then save the form a value of 12:30pm becomes 11:30am.
- Status changed to Needs work
12 months ago 4:51pm 2 April 2024 - 🇬🇧United Kingdom jonathan1055
Thanks @DamienMcKenna for re-rolling. Yes I like your idea of a single comment at the top of the fieldset.
If you want to convert to a MR then please do that, as then we will see the phpunit tests even when there are phpcs errors that need fixing. - last update
12 months ago Build Successful - last update
12 months ago Build Successful - last update
12 months ago Build Successful - last update
12 months ago 227 pass - last update
12 months ago 227 pass - 🇬🇧United Kingdom jonathan1055
Your MR127 was many commits behind the current 2.x dev branch and the initial pipelines were running with old code, had fewer test jobs, and the cspell & phpstan were failing. I didn't when the issue fork was created, but if that was a while ago it would explain this. I simply added a comment
/rebase
to the MR overview page and this rebased the branch, no problem. You can see the pipeline now has more jobs, but all pass green. - 🇺🇸United States DamienMcKenna NH, USA
How about going a step further and just showing what the current time is according to the server, so that the person can know what time they're working in relation to?