- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 5:56am 20 January 2023 - Status changed to Needs work
3 months ago 10:27am 21 August 2024 - 🇵🇭Philippines cleavinjosh
Hi @Sonalmg,
I applied MR!4, it was applied smoothly and fixed most of the phpcs issues.
These are the remaining issues after I ran
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml
:➜ iframe_video git:(1.0.2) curl https://git.drupalcode.org/project/iframe_video/-/merge_requests/4.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 1709 0 1709 0 0 3896 0 --:--:-- --:--:-- --:--:-- 3892 patching file iframe_video.info.yml patching file iframe_video.module patching file src/Plugin/media/Source/IframeVideo.php ➜ iframe_video git:(1.0.2) ✗ .. ➜ contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig iframe_video FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/iframe_video/iframe_video.info.yml ------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------------- 7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" 8 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" 9 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" ------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/iframe_video/src/Form/IframeForm.php -------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------- 14 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\media_library\Form\AddFormBase. -------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/iframe_video/src/Plugin/media/Source/IframeVideo.php ------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------- 24 | ERROR | [x] Expected 1 blank line before function; 0 found ------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------- Time: 122ms; Memory: 10MB ➜ contrib
Moreover, MR!4 is 3 commits behind the target branch.
Thank you.