[warning] array_flip(): Can only flip STRING and INTEGER values, when saving a non-revisionable custom content entity

Since there hasn't been a follow up to #9 going to close for now.

If still a bug please reopen addressing #9

Thanks all!

Reopening the issue since the problem is still here on D10.2.3.

This is the relevant part of the stacktrace:

EntityChangesDetectionTrait.php:34, Drupal\Core\Entity\ContentEntityBase->traitGetFieldsToSkipFromTranslationChangesCheck()
ContentEntityBase.php:1434, Drupal\Core\Entity\ContentEntityBase->getFieldsToSkipFromTranslationChangesCheck()
ContentEntityBase.php:1475, Drupal\Core\Entity\ContentEntityBase->hasTranslationChanges()
ChangedItem.php:49, Drupal\Core\Field\Plugin\Field\FieldType\ChangedItem->preSave()
FieldItemList.php:233, Drupal\Core\Field\FieldItemList->delegateMethod()
FieldItemList.php:191, Drupal\Core\Field\FieldItemList->preSave()
ContentEntityStorageBase.php:938, Drupal\Core\Entity\ContentEntityStorageBase->invokeFieldMethod()
ContentEntityStorageBase.php:888, Drupal\Core\Entity\ContentEntityStorageBase->invokeHook()
EntityStorageBase.php:529, Drupal\Core\Entity\EntityStorageBase->doPreSave()
ContentEntityStorageBase.php:753, Drupal\Core\Entity\ContentEntityStorageBase->doPreSave()
EntityStorageBase.php:483, Drupal\Core\Entity\EntityStorageBase->save()
SqlContentEntityStorage.php:806, Drupal\Core\Entity\Sql\SqlContentEntityStorage->save()
EntityBase.php:352, Drupal\Core\Entity\EntityBase->save()
...

@larowlan

Looking at \Drupal\Core\Entity\ContentEntityStorageBase::populateAffectedRevisionTranslations which I think would be the calling parent here, can you check if it gets inside the if statement

    if ($this->entityType->isTranslatable() && $this->entityType->isRevisionable()) {

I suspect it should not, so you might need to check those two methods.

Up until the array_flip that throws the warning, the \Drupal\Core\Entity\ContentEntityStorageBase::populateAffectedRevisionTranslations is not called at all.

I created a merge request.

efpapado → closed merge request !8394

Hiding the patch file, as a MR has now been used, and changing the version to 11.x

This may count as not needing tests but think should least include a comment for the change.

Pushed new commit with a comment as requested.

Going to lean on this being small enough to not need test coverage so will mark.

I feel this one is valid enough to add tests for.

\Drupal\entity_test\Entity\EntityTest in core only has a base table, no data table etc.