Option to process Geocode conversation using a queue.

Created on 3 June 2022, almost 3 years ago
Updated 4 February 2024, about 1 year ago

Problem/Motivation

Sometimes the conversion takes time based on the plugin used to geocode the fields, which keeps the node save on hold, and the user waiting for the node to be saved. This can get even heavier when webform are used to populate the node's data and include Geo conversion for address fields.

Proposed resolution

Update geocoder_field_entity_presave() to add items to the queue and be processed via cron at a later time as defined.
Admin option in settings at global level to enable/disable processing via a queue.

Remaining tasks

  1. Update/Review Proposed resolution
  2. Implement the Proposed solution
Feature request
Status

Needs review

Version

3.0

Component

Code

Created by

🇮🇳India joshua1234511 Goa

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update about 1 year ago
    PHPLint Failed
  • Pipeline finished with Failed
    about 1 year ago
    Total: 44s
    #87498
  • 🇧🇪Belgium dieterholvoet Brussels

    DieterHolvoet changed the visibility of the branch 8.x-4.x to hidden.

  • Merge request !48Add queueing → (Open) created by dieterholvoet
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update about 1 year ago
    PHPLint Failed
  • Pipeline finished with Success
    about 1 year ago
    #87505
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update about 1 year ago
    PHPLint Failed
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update about 1 year ago
    PHPLint Failed
  • Pipeline finished with Failed
    about 1 year ago
    Total: 136s
    #87556
  • Pipeline finished with Success
    about 1 year ago
    Total: 262s
    #87557
  • Status changed to Needs review about 1 year ago
  • 🇧🇪Belgium dieterholvoet Brussels

    I started a new branch from 4.x and improved the implementation, both in the old 3.x and new 4.x branch:

    • Simplified some naming and labels
    • Moved the queue ID to a constant
    • Stopped storing the whole entity object in the queue item data. Makes the row unnecessary big & makes it so the queue worker gets a possibly outdated version of the entity.
    • Removed the drupal_register_shutdown_function. Instead, I added a check that only saves the entity if any values were changed, also preventing infinite loops but without needing hacky code.
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update about 1 year ago
    run-tests.sh fatal error
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update about 1 year ago
    run-tests.sh fatal error
  • Pipeline finished with Failed
    about 1 year ago
    #87568
  • Pipeline finished with Success
    about 1 year ago
    Total: 174s
    #87569
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update about 1 year ago
    run-tests.sh fatal error
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update about 1 year ago
    run-tests.sh fatal error
  • Pipeline finished with Failed
    about 1 year ago
    #87572
  • Pipeline finished with Success
    about 1 year ago
    Total: 145s
    #87573
  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update about 1 year ago
    Not currently mergeable.
  • Pipeline finished with Success
    about 1 year ago
    Total: 176s
    #120677
  • Pipeline finished with Success
    about 1 year ago
    Total: 177s
    #120678
  • Pipeline finished with Success
    about 1 year ago
    Total: 178s
    #120679
  • Pipeline finished with Success
    about 1 year ago
    Total: 161s
    #120681
  • Pipeline finished with Success
    12 months ago
    Total: 149s
    #164806
  • Pipeline finished with Success
    4 months ago
    Total: 211s
    #379995
  • Pipeline finished with Success
    4 months ago
    Total: 214s
    #379994
  • Pipeline finished with Success
    4 months ago
    Total: 229s
    #379996
  • Pipeline finished with Success
    4 months ago
    Total: 238s
    #379997
Production build 0.71.5 2024