- last update
about 1 year ago 30 pass, 2 fail - last update
10 months ago 48 pass - π·π΄Romania amateescu
I think we should take a much simpler approach and just check if the Workspaces module is enabled, and allow alias generation if a workspace is active.
I think we should take a much simpler approach and just check if the Workspaces module is enabled, and allow alias generation if a workspace is active.
That's more or less what I had in the beginning of the MR.
- last update
10 months ago 48 pass - π·π΄Romania amateescu
We also need to skip generating path aliases when a workspace is published, here's an update for that.
- Status changed to Needs work
6 months ago 9:28am 1 August 2024 - π¨πSwitzerland berdir Switzerland
Fine with that, but needs to be a merge request now. Tests would be great, but I think I can also live without that given that it's a fairly simple check.
- π·π΄Romania amateescu
amateescu β changed the visibility of the branch 3283769-path-generation-inside to hidden.
- Status changed to Needs review
5 months ago 9:40am 16 August 2024 - π·π΄Romania amateescu
Thanks for reviewing :) Opened a new MR starting from the patch in #10 and added test coverage for the synchronizable check.
Didn't add a new test for allowing path generation inside a workspace because I think that part could be fixed in a more generic way by rolling back #2847672: Only generate aliases for the default revision β and start creating pending revision for path aliases if the parent entity is also a pending revision, but I think that should be a new issue.
- heddn Nicaragua
The fixes here look great. Tests were also added. LGTM